Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scylla_database_reads_memory_consumption shows *free* memory for the system semaphore #13810

Closed
michoecho opened this issue May 8, 2023 · 2 comments
Closed

scylla_database_reads_memory_consumption shows *free* memory for the system semaphore #13810

michoecho opened this issue May 8, 2023 · 2 comments
Assignees
@michoecho
Milestone
5.3

Comments

@michoecho
Copy link
Contributor

The metric is supposed to show consumed memory, as its name suggests, but it shows available memory instead.
@michoecho michoecho self-assigned this May 8, 2023
michoecho added a commit to michoecho/scylla that referenced this issue May 8, 2023
@michoecho
database: fix reads_memory_consumption for system semaphore
c3619e3 
The metric shows the opposite of what its name suggests.
It shows available memory rather than consumed memory.
Fix that.

Fixes scylladb#13810
@michoecho michoecho mentioned this issue May 8, 2023
Closed
@michoecho
Copy link
Contributor Author

Regressed in dcd2deb.

@mykaul mykaul added this to the 5.3 milestone May 8, 2023
denesb pushed a commit that referenced this issue Dec 15, 2023
@michoecho @denesb
database: fix reads_memory_consumption for system semaphore
593b7b3 
The metric shows the opposite of what its name suggests.
It shows available memory rather than consumed memory.
Fix that.

Fixes #13810

Closes #13811

(cherry picked from commit 0813fa1)
@denesb
Copy link
Contributor

denesb commented Dec 15, 2023

Backported to 5.2.

denesb pushed a commit that referenced this issue Dec 15, 2023
@michoecho @denesb
database: fix reads_memory_consumption for system semaphore
3af6dfe 
The metric shows the opposite of what its name suggests.
It shows available memory rather than consumed memory.
Fix that.

Fixes #13810

Closes #13811

(cherry picked from commit 0813fa1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michoecho michoecho

Labels
None yet
Projects
None yet
Milestone
5.3
Development

Successfully merging a pull request may close this issue.

database: fix reads_memory_consumption for system semaphore michoecho/scylla
4 participants
@denesb @mykaul @scylladb-promoter @michoecho