Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compaction: excessive reallocation during input list formatting #14071

Closed
bhalevy opened this issue May 29, 2023 · 7 comments
Closed

compaction: excessive reallocation during input list formatting #14071

bhalevy opened this issue May 29, 2023 · 7 comments
Labels
area/compaction P1 Urgent symptom/stalls
Milestone
5.4

Comments

@bhalevy
Copy link
Member

bhalevy commented May 29, 2023

As @raphaelsc said in #13907:

with off-strategy, input list size can be close to 1k, which will lead to unneeded reallocations when formatting the list for logging.

in the past, we faced stalls in this area, and excessive reallocation (log2 ~1k = ~10) may have contributed to that.
@bhalevy
Copy link
Member Author

bhalevy commented May 29, 2023

Fixed in #13907 by 5544d12

@bhalevy bhalevy closed this as completed May 29, 2023
@DoronArazii DoronArazii added this to the 5.4 milestone Jun 20, 2023
@bhalevy bhalevy mentioned this issue Jul 6, 2023
Closed
@DoronArazii DoronArazii added backport/5.2 Issues that should be backported to 5.2 branch once they'll be fixed Requires-Backport-to-5.1 labels Jul 9, 2023
@DoronArazii
Copy link

DoronArazii commented Jul 9, 2023 •
edited

@scylladb/scylla-maint please consider backport to all active OSS versions + 2022.1 (@bhalevy we might need another PR on the other repo for 2022.1)

avikivity pushed a commit that referenced this issue Jul 9, 2023
@raphaelsc @avikivity
compaction: avoid excessive reallocation and during input list format…
55edbde 
…ting

with off-strategy, input list size can be close to 1k, which will
lead to unneeded reallocations when formatting the list for
logging.

in the past, we faced stalls in this area, and excessive reallocation
(log2 ~1k = ~10) may have contributed to that.

Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>

Closes #13907

(cherry picked from commit 5544d12)

Fixes #14071
avikivity pushed a commit that referenced this issue Jul 9, 2023
@raphaelsc @avikivity
compaction: avoid excessive reallocation and during input list format…
e7a5c13 
…ting

with off-strategy, input list size can be close to 1k, which will
lead to unneeded reallocations when formatting the list for
logging.

in the past, we faced stalls in this area, and excessive reallocation
(log2 ~1k = ~10) may have contributed to that.

Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>

Closes #13907

(cherry picked from commit 5544d12)

Fixes #14071
@avikivity
Copy link
Member

Backported to 5.2, 5.1. 5.3 already had the fix.

@DoronArazii
Copy link

@avikivity did you forgot to remove the labels? or it's in purpose?

@DoronArazii DoronArazii removed backport/5.2 Issues that should be backported to 5.2 branch once they'll be fixed Requires-Backport-to-5.1 labels Jul 10, 2023
@avikivity
Copy link
Member

Forgot.

@pdbossman
Copy link

I don't quite understand the mapping from OSS to enterprise yet and it's not explicitly mentioned - what release of 2022.2.x is this coming in?

@bhalevy
Copy link
Member Author

bhalevy commented Jul 28, 2023

I don't quite understand the mapping from OSS to enterprise yet and it's not explicitly mentioned - what release of 2022.2.x is this coming in?

According to https://github.com/scylladb/scylla-enterprise/commits/branch-2022.2
it's going to be 2022.2.12

@raphaelsc raphaelsc mentioned this issue Aug 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/compaction P1 Urgent symptom/stalls
Projects
None yet
Milestone
5.4
Development

No branches or pull requests
5 participants
@avikivity @mykaul @pdbossman @bhalevy @DoronArazii