New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reject LIMIT without any value #14705
Comments
avikivity
added a commit
to avikivity/scylladb
that referenced
this issue
Jul 14, 2023
The grammar mistakenly allows nothing to be parsed as an intValue (itself accepted in LIMIT and similar clauses). Easily fixed by removing the empty alternative. A unit test is added. Fixes scylladb#14705.
avikivity
added a commit
to avikivity/scylladb
that referenced
this issue
Jul 19, 2023
The grammar mistakenly allows nothing to be parsed as an intValue (itself accepted in LIMIT and similar clauses). Easily fixed by removing the empty alternative. A unit test is added. Fixes scylladb#14705.
avikivity
added a commit
to avikivity/scylladb
that referenced
this issue
Jul 20, 2023
The grammar mistakenly allows nothing to be parsed as an intValue (itself accepted in LIMIT and similar clauses). Easily fixed by removing the empty alternative. A unit test is added. Fixes scylladb#14705.
patjed41
pushed a commit
to patjed41/scylladb
that referenced
this issue
Jul 27, 2023
The grammar mistakenly allows nothing to be parsed as an intValue (itself accepted in LIMIT and similar clauses). Easily fixed by removing the empty alternative. A unit test is added. Fixes scylladb#14705. Closes scylladb#14707
Backported to 5.1, 5.2. 5.4 already has it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The CQL grammar allows to specify
LIMIT
orPER PARTITION LIMIT
without any value.Scylla should reject such queries.
On current Scylla the query fails on an internal type check, which is okayish, but on previous versions of Scylla it causes
on_internal_error
.We should update the grammar so that the parser rejects such queries.
Scylla version (or git commit hash):
5.4.0~dev-0.20230714.033e5348aa82
The text was updated successfully, but these errors were encountered: