New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc::topology_description
: avoid large allocation
#15302
Comments
Lists can grow very big. Let's use a chunked vector to prevent large contiguous allocations. Fixes: scylladb#15302.
Lists can grow very big. Let's use a chunked vector to prevent large contiguous allocations. Fixes: scylladb#15302.
Lists can grow very big. Let's use a chunked vector to prevent large contiguous allocations. Fixes: scylladb#15302.
Doesn't apply cleanly. Since this was done by an external contributor, @kbr-scylla can you please take care of backporting this? |
Backported to 5.2 |
I backported to open source, but forgot about the ancient enterprise LTS versions. Need to backport there too |
Queued backports to enterprise branches: |
As observed in https://github.com/scylladb/scylla-enterprise/issues/3387#issuecomment-1706965061, the
vector
may cause a large allocation -- there could be manytoken_range_descriptions
(it'snumber_of_nodes * vnodes_per_node
).We need to change this to
chunked_vector
, for example.The text was updated successfully, but these errors were encountered: