[5.2] test_restoring_by_schema_with_mv_use_sstableloader fails due to scylla-specific options in schema description

[bhalevy]

Seen in https://jenkins.scylladb.com/job/scylla-5.2/job/dtest-release/40/testReport/snapshot_test/TestSchemaFileInSnapshot/Run_Dtest_Parallel_Cloud_Machines___FullDtest___full_split000___test_restoring_by_schema_with_mv_use_sstableloader/

>       assert schema_table_desc == restored_base_table_desc
E       assert ('\n'\n 'CREATE TABLE ks.cf (\n'\n '    key int PRIMARY KEY,\n'\n '    val text\n'\n ') WITH bloom_filter_fp_chance = 0.01\n'\n "    AND caching = {'keys': 'ALL', 'rows_per_partition': 'ALL'}\n"\n "    AND comment = 'test cf'\n"\n "    AND compaction = {'class': 'SizeTieredCompactionStrategy', 'enabled': "\n "'true'}\n"\n '    AND compression = {}\n'\n '    AND crc_check_chance = 1.0\n'\n '    AND dclocal_read_repair_chance = 0.0\n'\n '    AND default_time_to_live = 0\n'\n '    AND gc_grace_seconds = 864000\n'\n '    AND max_index_interval = 2048\n'\n '    AND memtable_flush_period_in_ms = 0\n'\n '    AND min_index_interval = 128\n'\n '    AND read_repair_chance = 0.0\n'\n "    AND speculative_retry = '99.0PERCENTILE';\n"\n '\n'\n 'CREATE MATERIALIZED VIEW ks.cf_mv AS\n'\n '    SELECT val, key\n'\n '    FROM ks.cf\n'\n '    WHERE val IS NOT null\n'\n '    PRIMARY KEY (val, key)\n'\n '    WITH CLUSTERING ORDER BY (key ASC)\n'\n '    AND bloom_filter_fp_chance = 0.01\n'\n "    AND caching = {'keys': 'ALL', 'rows_per_partition': 'ALL'}\n"\n "    AND comment = ''\n"\n "    AND compaction = {'class': 'SizeTieredCompactionStrategy'}\n"\n "    AND compression = {'sstable_compression': "\n "'org.apache.cassandra.io.compress.LZ4Compressor'}\n"\n '    AND crc_check_chance = 1.0\n'\n '    AND dclocal_read_repair_chance = 0.0\n'\n '    AND default_time_to_live = 0\n'\n '    AND gc_grace_seconds = 864000\n'\n '    AND max_index_interval = 2048\n'\n '    AND memtable_flush_period_in_ms = 0\n'\n '    AND min_index_interval = 128\n'\n '    AND read_repair_chance = 0.0\n'\n "    AND speculative_retry = '99.0PERCENTILE';\n"\n '\n') == ('\n'\n 'CREATE TABLE ks.cf (\n'\n '    key int PRIMARY KEY,\n'\n '    val text\n'\n ') WITH bloom_filter_fp_chance = 0.01\n'\n "    AND caching = {'keys': 'ALL', 'rows_per_partition': 'ALL'}\n"\n "    AND comment = 'test cf'\n"\n "    AND compaction = {'class': 'SizeTieredCompactionStrategy', 'enabled': "\n "'true'}\n"\n '    AND compression = {}\n'\n '    AND crc_check_chance = 1.0\n'\n '    AND dclocal_read_repair_chance = 0.0\n'\n '    AND default_time_to_live = 0\n'\n '    AND gc_grace_seconds = 864000\n'\n '    AND max_index_interval = 2048\n'\n '    AND memtable_flush_period_in_ms = 0\n'\n '    AND min_index_interval = 128\n'\n '    AND read_repair_chance = 0.0\n'\n "    AND speculative_retry = '99.0PERCENTILE';\n"\n '\n'\n 'CREATE MATERIALIZED VIEW ks.cf_mv AS\n'\n '    SELECT val, key\n'\n '    FROM ks.cf\n'\n '    WHERE val IS NOT null\n'\n '    PRIMARY KEY (val, key)\n'\n '    WITH CLUSTERING ORDER BY (key ASC)\n'\n '    AND bloom_filter_fp_chance = 0.01\n'\n "    AND caching = {'keys': 'ALL', 'rows_per_partition': 'ALL'}\n"\n "    AND comment = ''\n"\n "    AND compaction = {'class': 'SizeTieredCompactionStrategy'}\n"\n "    AND compression = {'sstable_compression': "\n "'org.apache.cassandra.io.compress.LZ4Compressor'}\n"\n '    AND crc_check_chance = 1.0\n'\n '    AND dclocal_read_repair_chance = 0.0\n'\n '    AND default_time_to_live = 0\n'\n '    AND gc_grace_seconds = 864000\n'\n '    AND max_index_interval = 2048\n'\n '    AND memtable_flush_period_in_ms = 0\n'\n '    AND min_index_interval = 128\n'\n '    AND read_repair_chance = 0.0\n'\n "    AND speculative_retry = '99.0PERCENTILE'\n"\n '\n'\n "scylla_tags = {'system:synchronous_view_updates': 'false'};\n"\n '\n')
E           
E           CREATE TABLE ks.cf (
E               key int PRIMARY KEY,
E               val text
E           ) WITH bloom_filter_fp_chance = 0.01
E               AND caching = {'keys': 'ALL', 'rows_per_partition': 'ALL'}
E               AND comment = 'test cf'
E               AND compaction = {'class': 'SizeTieredCompactionStrategy', 'enabled': 'true'}
E               AND compression = {}
E               AND crc_check_chance = 1.0
E               AND dclocal_read_repair_chance = 0.0
E               AND default_time_to_live = 0
E               AND gc_grace_seconds = 864000
E               AND max_index_interval = 2048
E               AND memtable_flush_period_in_ms = 0
E               AND min_index_interval = 128
E               AND read_repair_chance = 0.0
E               AND speculative_retry = '99.0PERCENTILE';
E           
E           CREATE MATERIALIZED VIEW ks.cf_mv AS
E               SELECT val, key
E               FROM ks.cf
E               WHERE val IS NOT null
E               PRIMARY KEY (val, key)
E               WITH CLUSTERING ORDER BY (key ASC)
E               AND bloom_filter_fp_chance = 0.01
E               AND caching = {'keys': 'ALL', 'rows_per_partition': 'ALL'}
E               AND comment = ''
E               AND compaction = {'class': 'SizeTieredCompactionStrategy'}
E               AND compression = {'sstable_compression': 'org.apache.cassandra.io.compress.LZ4Compressor'}
E               AND crc_check_chance = 1.0
E               AND dclocal_read_repair_chance = 0.0
E               AND default_time_to_live = 0
E               AND gc_grace_seconds = 864000
E               AND max_index_interval = 2048
E               AND memtable_flush_period_in_ms = 0
E               AND min_index_interval = 128
E               AND read_repair_chance = 0.0
E         -     AND speculative_retry = '99.0PERCENTILE'
E         +     AND speculative_retry = '99.0PERCENTILE';
E         ?                                             +
E           
E         - scylla_tags = {'system:synchronous_view_updates': 'false'};
E         -

snapshot_test.py:1236: AssertionError

The cause must be 29da20b

[mykaul]

#14924 was not backported to 5.2.

[denesb]

So what is the action item here? Do we need to backport #14924?

[bhalevy]

So what is the action item here? Do we need to backport #14924?

Looks so, since the dtest issue https://github.com/scylladb/scylla-dtest/issues/3324 is not fixed yet

[denesb]

Backported #14924.

[mykaul]

@dani-tweig - we don't have an open 5.2.x milestone? This should be set to such, I reckon.

[dani-tweig]

@mykaul
Added to 5.2.16

[denesb]

Closed by 0d22471.