Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema::describe: print synchronous_updates only when it's present in extension map #14924

Closed
Jadw1 opened this issue Aug 2, 2023 · 3 comments
Closed

schema::describe: print synchronous_updates only when it's present in extension map #14924

Jadw1 opened this issue Aug 2, 2023 · 3 comments
Assignees
@Jadw1
Milestone
5.4

Comments

@Jadw1
Copy link
Contributor

Jadw1 commented Aug 2, 2023

Currently synchronous_updates is printed always in materialized view's description. It is not necessary to print it when the key is not present in schema's extension map.

Refers: https://github.com/scylladb/scylla-dtest/issues/3324
@Jadw1 Jadw1 self-assigned this Aug 2, 2023
Jadw1 added a commit to Jadw1/scylla that referenced this issue Aug 2, 2023
@Jadw1
schema::describe: print 'synchronous_updates' only if it was specified
3a7db87 
While describing materialized view, print `synchronous_updates` option
only if the tag is present in schema's extensions map. Previously if the
key wasn't present, the default (false) value was printed.

Fixes: scylladb#14924
@Jadw1 Jadw1 mentioned this issue Aug 2, 2023
Closed
Jadw1 added a commit to Jadw1/scylla that referenced this issue Aug 2, 2023
@Jadw1
schema::describe: print 'synchronous_updates' only if it was specified
a693ee4 
While describing materialized view, print `synchronous_updates` option
only if the tag is present in schema's extensions map. Previously if the
key wasn't present, the default (false) value was printed.

Fixes: scylladb#14924
@Jadw1 Jadw1 mentioned this issue Aug 2, 2023
Closed
@nyh
Copy link
Contributor

nyh commented Aug 4, 2023

It isn't necessary, that's true, but what's the downside to print it?
Moreover, what do we do for other options that have defaults, do we print the default or not? If we do, why should this option get a different treatment?
(I don't consider a dtest a convincing-enough reason...)

@DoronArazii DoronArazii added this to the 5.4 milestone Aug 29, 2023
@denesb
Copy link
Contributor

denesb commented Dec 18, 2023

Minor UX improvement, not backporting.

@mykaul mykaul mentioned this issue Feb 18, 2024
Closed
denesb pushed a commit that referenced this issue Feb 19, 2024
@Jadw1 @denesb
schema::describe: print 'synchronous_updates' only if it was specified
0d22471 
While describing materialized view, print `synchronous_updates` option
only if the tag is present in schema's extensions map. Previously if the
key wasn't present, the default (false) value was printed.

Fixes: #14924

Closes #14928

(cherry picked from commit b92d473)
@denesb
Copy link
Contributor

denesb commented Feb 19, 2024

Backported to 5.2, this is a follow-up fox for #12389.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jadw1 Jadw1

Labels
None yet
Projects
None yet
Milestone
5.4
5 participants
@nyh @denesb @Jadw1 @scylladb-promoter @DoronArazii