Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mixing token and partition key restrictions #2060

Open
slivne opened this issue Feb 5, 2017 · 1 comment
Open

Allow mixing token and partition key restrictions #2060

slivne opened this issue Feb 5, 2017 · 1 comment
Assignees
@ptrsmrn
Labels
area/cassandra 2.2 compatibility area/cql
Milestone
x-ray

Comments

@slivne
Copy link
Contributor

slivne commented Feb 5, 2017

Mirror of https://issues.apache.org/jira/browse/CASSANDRA-7016
@slivne slivne modified the milestones: Yellowfin, x-ray Feb 5, 2017
@nyh
Copy link
Contributor

nyh commented Mar 8, 2023 •
edited

Reproduced by translated Cassandra test:

  • cassandra_tests/validation/operations/select_group_by_test.py::testGroupByWithoutPaging

nyh added a commit to nyh/scylla that referenced this issue Mar 9, 2023
@nyh
cql-pytest: translate Cassandra's tests for GROUP BY
3868a32 
This is a translation of Cassandra's CQL unit test source file
validation/operations/SelectGroupByTest.java into our cql-pytest
framework.

This test file contains only 8 separate test functions, but each of them
is very long checking hundreds of different combinations of GROUP BY with
other things like LIMIT, ORDER BY, etc., so 6 out of the 7 tests fail on
Scylla on one of the bugs listed below - most of the tests actually fail
in multiple places due to multiple bugs. All tests pass on Cassandra.

The tests reproduce six already-known Scylla issues and one new issue:

Already known issues:

Refs scylladb#2060: Allow mixing token and partition key restrictions
Refs scylladb#5361: LIMIT doesn't work when using GROUP BY
Refs scylladb#5362: LIMIT is not doing it right when using GROUP BY
Refs scylladb#5363: PER PARTITION LIMIT doesn't work right when using GROUP BY
Refs scylladb#12477: Combination of COUNT with GROUP BY is different from Cassandra
             in case of no matches
Refs scylladb#12479: SELECT DISTINCT should refuse GROUP BY with clustering column

A new issue discovered by these tests:

Refs scylladb#13109: Incorrect sort order when combining IN, GROUP BY and ORDER BY

Signed-off-by: Nadav Har'El <nyh@scylladb.com>
@nyh nyh mentioned this issue Mar 9, 2023
Closed
denesb pushed a commit that referenced this issue Mar 15, 2023
@nyh @denesb
cql-pytest: translate Cassandra's tests for GROUP BY
543d4ed 
This is a translation of Cassandra's CQL unit test source file
validation/operations/SelectGroupByTest.java into our cql-pytest
framework.

This test file contains only 8 separate test functions, but each of them
is very long checking hundreds of different combinations of GROUP BY with
other things like LIMIT, ORDER BY, etc., so 6 out of the 7 tests fail on
Scylla on one of the bugs listed below - most of the tests actually fail
in multiple places due to multiple bugs. All tests pass on Cassandra.

The tests reproduce six already-known Scylla issues and one new issue:

Already known issues:

Refs #2060: Allow mixing token and partition key restrictions
Refs #5361: LIMIT doesn't work when using GROUP BY
Refs #5362: LIMIT is not doing it right when using GROUP BY
Refs #5363: PER PARTITION LIMIT doesn't work right when using GROUP BY
Refs #12477: Combination of COUNT with GROUP BY is different from Cassandra
             in case of no matches
Refs #12479: SELECT DISTINCT should refuse GROUP BY with clustering column

A new issue discovered by these tests:

Refs #13109: Incorrect sort order when combining IN, GROUP BY and ORDER BY

Signed-off-by: Nadav Har'El <nyh@scylladb.com>

Closes #13126
@kostja kostja assigned ptrsmrn and unassigned eliransin Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptrsmrn ptrsmrn

Labels
area/cassandra 2.2 compatibility area/cql
Projects
None yet
Milestone
x-ray
Development

No branches or pull requests
4 participants
@nyh @slivne @eliransin @ptrsmrn