Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodetool drain #442

Closed
tzach opened this issue Oct 7, 2015 · 14 comments
Closed

nodetool drain #442

tzach opened this issue Oct 7, 2015 · 14 comments

Comments

@tzach
Copy link
Contributor

tzach commented Oct 7, 2015

@tzach tzach added this to the GA milestone Oct 7, 2015
@slivne slivne modified the milestones: firefish, GA Dec 22, 2015
@tzach tzach modified the milestones: GA, firefish Dec 29, 2015
@tzach
Copy link
Contributor Author

tzach commented Dec 29, 2015

@slivne drain is for GA, and not implemented yet

@penberg
Copy link
Contributor

penberg commented Dec 29, 2015

@tzach @slivne, really? I thought 39af3ec added nodetool drain support?

Ping @pdziepak

@pdziepak
Copy link
Contributor

It should be available at REST API level. Perhaps some glue code in scylla-jmx is missing.

@penberg
Copy link
Contributor

penberg commented Dec 29, 2015

StorageService.drain() seems to have the necessary glue. @tzach, hmm?

@tzach
Copy link
Contributor Author

tzach commented Dec 29, 2015

I tested with 0.13.2 and its not there

nodetool drain
error: API call is not supported yet

@amnonh
Copy link
Contributor

amnonh commented Dec 29, 2015

assign it to me

@tzach tzach assigned amnonh and unassigned pdziepak Dec 29, 2015
@penberg
Copy link
Contributor

penberg commented Dec 29, 2015

@tzach It's in master, not in 0.13.2.

@tzach
Copy link
Contributor Author

tzach commented Dec 29, 2015

I can't keep up with you youngsters, I only test RPMs
For 0.13.2 the HTTP is not avilable either

curl -X POST --header "Content-Type: application/json" --header "Accept: application/json" "http://localhost:10000/storage_service/drain"
{"message": "API call is not supported yet", "code": 500}

@amnonh
Copy link
Contributor

amnonh commented Dec 29, 2015

I've just check it on head and it works.
So wait for the next release and try again

On Tue, Dec 29, 2015 at 5:24 PM, Tzach Livyatan notifications@github.com
wrote:

I can't keep up with you youngsters, I only test RPMs
For 0.13.2 the HTTP is not avilable either

curl -X POST --header "Content-Type: application/json" --header "Accept: application/json" "http://localhost:10000/storage_service/drain"
{"message": "API call is not supported yet", "code": 500}


Reply to this email directly or view it on GitHub
#442 (comment).

@slivne
Copy link
Contributor

slivne commented Dec 29, 2015

there is still a discussion between gleb and pawel (unless they sorted it
out) on impl items in drain.

On Tue, Dec 29, 2015 at 5:30 PM, Amnon Heiman notifications@github.com
wrote:

I've just check it on head and it works.
So wait for the next release and try again

On Tue, Dec 29, 2015 at 5:24 PM, Tzach Livyatan notifications@github.com
wrote:

I can't keep up with you youngsters, I only test RPMs
For 0.13.2 the HTTP is not avilable either

curl -X POST --header "Content-Type: application/json" --header "Accept:
application/json" "http://localhost:10000/storage_service/drain"
{"message": "API call is not supported yet", "code": 500}


Reply to this email directly or view it on GitHub
#442 (comment).


Reply to this email directly or view it on GitHub
#442 (comment).

@amnonh
Copy link
Contributor

amnonh commented Dec 29, 2015

I'm not sure how well it works, but you don't get the experience Tzach was
getting.

Now the drain command completed without any errors.
And scylla prints to the log that it runs drain

On Tue, Dec 29, 2015 at 5:33 PM, slivne notifications@github.com wrote:

there is still a discussion between gleb and pawel (unless they sorted it
out) on impl items in drain.

On Tue, Dec 29, 2015 at 5:30 PM, Amnon Heiman notifications@github.com
wrote:

I've just check it on head and it works.
So wait for the next release and try again

On Tue, Dec 29, 2015 at 5:24 PM, Tzach Livyatan <
notifications@github.com>
wrote:

I can't keep up with you youngsters, I only test RPMs
For 0.13.2 the HTTP is not avilable either

curl -X POST --header "Content-Type: application/json" --header
"Accept:
application/json" "http://localhost:10000/storage_service/drain"
{"message": "API call is not supported yet", "code": 500}


Reply to this email directly or view it on GitHub
<#442 (comment)
.


Reply to this email directly or view it on GitHub
#442 (comment).


Reply to this email directly or view it on GitHub
#442 (comment).

@tzach tzach added the high label Jan 12, 2016
@slivne
Copy link
Contributor

slivne commented Feb 4, 2016

@pdziepak I know we have talked about this - is there still something missing for this ?

@slivne
Copy link
Contributor

slivne commented Feb 18, 2016

@pdziepak , @gleb-cloudius is there still an opem item here ?

@pdziepak
Copy link
Contributor

On 18 February 2016 at 00:49, slivne notifications@github.com wrote:

@pdziepak https://github.com/pdziepak , @gleb-cloudius
https://github.com/gleb-cloudius is there still an opem item here ?

Drain is implemented and working correctly. There is a regression that
causes segmentation fault when shutting down drained node, but I've just
sent a patch to fix it.

@slivne slivne closed this as completed Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants