Not able to run CQL3 CREATE TABLE on head

[slivne]

with head at

commit 40c5173
Merge: dce642f 9887bc5
Author: Avi Kivity avi@cloudius-systems.com
Date: Thu Jul 30 08:24:05 2015 +0300

Merge "Implement missing fields for legacy_schema_tables" from Glauber

"Issue #8 mentions the fact that we are missing some fields in legacy_schema_tables.

After this patchset, the only one missing is the subcomparator. That one only exists
for super tables - which we don't support - and will be null otherwise: so we don't
really need it."

running
cqlsh> CREATE KEYSPACE keyspace3 WITH REPLICATION = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 };
cqlsh> CREATE TABLE keyspace3.standard1 ( key blob PRIMARY KEY, C0 blob, C1 blob, C2 blob, C3 blob, C4 blob);
<ErrorMessage code=0000 [Server error] message="not implemented">

fails

a bit more info

rm -Rf tmp/* ; gdb --args build/release/scylla --datadir tmp --commitlog-directory tmp --smp 1 --default-log-level info

 [shard 0] Migration Manager - Create new table: standard1
Catchpoint 1 (exception thrown), __cxxabiv1::__cxa_throw (obj=0x6000006bd740, tinfo=0x11c03a0 <typeinfo for std::system_error@@GLIBCXX_3.4.11>, dest=0x40d5b0 <std::system_error::~system_error()@plt>)
    at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:63
63    PROBE2 (throw, obj, tinfo);
(gdb) where
#0  __cxxabiv1::__cxa_throw (obj=0x6000006bd740, tinfo=0x11c03a0 <typeinfo for std::system_error@@GLIBCXX_3.4.11>, dest=0x40d5b0 <std::system_error::~system_error()@plt>)
    at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:63
#1  0x000000000044a493 in throw_if_error (this=<synthetic pointer>) at core/reactor.cc:89
#2  operator() (__closure=<optimized out>, sr=...) at core/reactor.cc:626
#3  apply (func=<optimized out>, args=<optimized out>) at core/apply.hh:34
#4  apply<reactor::make_directory(sstring)::<lambda(syscall_result<int>)>, syscall_result<int> > (func=<optimized out>, args=<optimized out>) at core/apply.hh:42
#5  apply<reactor::make_directory(sstring)::<lambda(syscall_result<int>)>, syscall_result<int> > (func=<optimized out>, args=<optimized out>) at core/future.hh:972
#6  operator()<future_state<syscall_result<int> > > (state=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x0, DIE 0x1f5fc9>, __closure=0x6000006797d8) at core/future.hh:637
#7  continuation<future<T>::then(Func&&, Param&&) [with Ret = void; Func = reactor::make_directory(sstring)::<lambda(syscall_result<int>)>; Param = future<T>::then(Func&&) [with Func = reactor::make_directory(sstring)::<lambda(syscall_result<int>)>; Result = future<>; T = {syscall_result<int>}]::<lambda(future_state<syscall_result<int> >&&)>; T = {syscall_result<int>}; futurize_t<Ret> = future<>]::<lambda(auto:1&&)>, syscall_result<int> >::run(void) (this=0x6000006797c0) at core/future.hh:333
#8  0x0000000000441062 in reactor::run_tasks (this=this@entry=0x6000001f7000, tasks=..., quota=<optimized out>) at core/reactor.cc:1040
#9  0x00000000004654fb in reactor::run (this=0x6000001f7000) at core/reactor.cc:1137
#10 0x00000000004adfbe in app_template::run(int, char**, std::function<void ()>&&) (this=this@entry=0x7fffffffd820, ac=ac@entry=9, av=av@entry=0x7fffffffda68, 
    func=func@entry=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x479acd, DIE 0x513cdd>) at core/app-template.cc:104
#11 0x0000000000419cf4 in main (ac=9, av=0x7fffffffda68) at main.cc:177
(gdb) c
Continuing.
 [shard 0] database - started compaction for column_family system/schema_keyspaces
 [shard 0] database - started compaction for column_family system/schema_columns
 [shard 0] database - started compaction for column_family system/schema_columnfamilies
Catchpoint 1 (exception thrown), __cxxabiv1::__cxa_throw (obj=0x6000000c8ac0, tinfo=0xc91610 <typeinfo for sstables::bufsize_mismatch_exception>, 
    dest=0x6437f0 <sstables::bufsize_mismatch_exception::~bufsize_mismatch_exception()>) at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:63
63    PROBE2 (throw, obj, tinfo);
(gdb) where
#0  __cxxabiv1::__cxa_throw (obj=0x6000000c8ac0, tinfo=0xc91610 <typeinfo for sstables::bufsize_mismatch_exception>, dest=0x6437f0 <sstables::bufsize_mismatch_exception::~bufsize_mismatch_exception()>)
    at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:63
#1  0x0000000000636890 in sstables::check_buf_size (buf=..., expected=expected@entry=2) at sstables/sstables.cc:124
#2  0x0000000000671028 in operator()<temporary_buffer<char> > (buf=..., __closure=0x6000006af208) at sstables/sstables.cc:149
#3  apply (args=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x20a273b, DIE 0x24d6c42>, func=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x20a273b, DIE 0x24d6c30>)
    at /home/shlomi/urchin/seastar/core/apply.hh:34
#4  apply<sstables::parse(sstables::random_access_reader&, T&) [with T = short unsigned int; std::enable_if_t<std::is_integral<_Tp>::value, future<> > = future<>]::<lambda(auto:31)>, temporary_buffer<char> > (
    args=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x20a273b, DIE 0x233823b>, func=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x20a273b, DIE 0x2338227>)
    at /home/shlomi/urchin/seastar/core/apply.hh:42
#5  apply<sstables::parse(sstables::random_access_reader&, T&) [with T = short unsigned int; std::enable_if_t<std::is_integral<_Tp>::value, future<> > = future<>]::<lambda(auto:31)>, temporary_buffer<char> > (
    args=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x20a273b, DIE 0x24d6c10>, func=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x20a273b, DIE 0x24d6bfd>)
    at /home/shlomi/urchin/seastar/core/future.hh:993
#6  operator()<future_state<temporary_buffer<char> > > (state=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x20a273b, DIE 0x24d6bc8>, __closure=0x6000006af1e8)
    at /home/shlomi/urchin/seastar/core/future.hh:637
#7  _ZN12continuationIZN6futureII16temporary_bufferIcEEE4thenIS0_IIEEZN8sstables5parseItEENSt9enable_ifIXsrSt11is_integralIT_E5valueES5_E4typeERNS6_20random_access_readerERSA_EUlSA_E_ZNS3_4thenISH_S5_EET0_OT_EUlO12future_stateIIS2_EEE_EEN8futurizeISK_E4typeEOSJ_OT1_EUlOSA_E_IS2_EE3runEv (this=0x6000006af1c0) at /home/shlomi/urchin/seastar/core/future.hh:333
#8  0x0000000000441062 in reactor::run_tasks (this=this@entry=0x6000001f7000, tasks=..., quota=<optimized out>) at core/reactor.cc:1040
#9  0x00000000004654fb in reactor::run (this=0x6000001f7000) at core/reactor.cc:1137
#10 0x00000000004adfbe in app_template::run(int, char**, std::function<void ()>&&) (this=this@entry=0x7fffffffd820, ac=ac@entry=9, av=av@entry=0x7fffffffda68, 
    func=func@entry=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x479acd, DIE 0x513cdd>) at core/app-template.cc:104
#11 0x0000000000419cf4 in main (ac=9, av=0x7fffffffda68) at main.cc:177
(gdb) c
Continuing.
Catchpoint 1 (exception thrown), __cxxabiv1::__cxa_throw (obj=0x6000000c8ac0, tinfo=0xcad2b0 <typeinfo for exceptions::read_timeout_exception>, 
    dest=0x7e3b60 <exceptions::read_timeout_exception::~read_timeout_exception()>) at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:63
63    PROBE2 (throw, obj, tinfo);
(gdb) where
#0  __cxxabiv1::__cxa_throw (obj=0x6000000c8ac0, tinfo=0xcad2b0 <typeinfo for exceptions::read_timeout_exception>, dest=0x7e3b60 <exceptions::read_timeout_exception::~read_timeout_exception()>)
    at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:63
#1  0x00000000007e8403 in std::make_exception_ptr<exceptions::read_timeout_exception> (__ex=...) at /usr/include/c++/4.9.2/bits/exception_ptr.h:174
#2  0x00000000007fa472 in set_exception<exceptions::read_timeout_exception> (e=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x4df0309, DIE 0x51531f9>, this=0x6000001094a8)
    at /home/shlomi/urchin/seastar/core/future.hh:439
#3  operator() (__closure=0x6000000ac1d8) at service/storage_proxy.cc:1398
#4  std::_Function_handler<void (), service::abstract_read_resolver::abstract_read_resolver(db::consistency_level, unsigned long, std::chrono::time_point<std::chrono::_V2::system_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > >)::{lambda()#1}>::_M_invoke(std::_Any_data const&) (__functor=...) at /usr/include/c++/4.9.2/functional:2039
#5  0x0000000000455ea3 in complete_timers<seastar::timer_set<timer<>, &timer<>::_link>, boost::intrusive::list<timer<>, boost::intrusive::member_hook<timer<>, boost::intrusive::list_member_hook<>, &timer<>::_link>, void, void>, reactor::run()::<lambda()>::<lambda()> > (this=<optimized out>, enable_fn=<optimized out>, expired_timers=..., timers=...) at core/reactor.hh:1114
#6  operator() (__closure=<optimized out>) at core/reactor.cc:1089
#7  std::_Function_handler<void(), reactor::run()::<lambda()> >::_M_invoke(const std::_Any_data &) (__functor=...) at /usr/include/c++/4.9.2/functional:2039
#8  0x00000000004421b4 in reactor::signals::poll_signal (this=0x6000001f7e18) at core/reactor.cc:171
#9  0x0000000000465521 in poll_once (this=0x6000001f7000) at core/reactor.cc:1168
#10 reactor::run (this=0x6000001f7000) at core/reactor.cc:1147
#11 0x00000000004adfbe in app_template::run(int, char**, std::function<void ()>&&) (this=this@entry=0x7fffffffd820, ac=ac@entry=9, av=av@entry=0x7fffffffda68, 
    func=func@entry=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x479acd, DIE 0x513cdd>) at core/app-template.cc:104
#12 0x0000000000419cf4 in main (ac=9, av=0x7fffffffda68) at main.cc:177
(gdb) c
Continuing.
Catchpoint 1 (exception thrown), __cxxabiv1::__cxa_throw (obj=0x6000000c8660, tinfo=0xcad2b0 <typeinfo for exceptions::read_timeout_exception>, 
    dest=0x7e3b60 <exceptions::read_timeout_exception::~read_timeout_exception()>) at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:63
63    PROBE2 (throw, obj, tinfo);
(gdb) where
#0  __cxxabiv1::__cxa_throw (obj=0x6000000c8660, tinfo=0xcad2b0 <typeinfo for exceptions::read_timeout_exception>, dest=0x7e3b60 <exceptions::read_timeout_exception::~read_timeout_exception()>)
    at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:63
#1  0x00000000007e8403 in std::make_exception_ptr<exceptions::read_timeout_exception> (__ex=...) at /usr/include/c++/4.9.2/bits/exception_ptr.h:174
#2  0x00000000007fa2e3 in set_exception<exceptions::read_timeout_exception> (e=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x4df0309, DIE 0x51531f9>, this=0x600000109538)
    at /home/shlomi/urchin/seastar/core/future.hh:439
#3  service::digest_read_resolver::on_timeout (this=0x600000109490) at service/storage_proxy.cc:1420
#4  0x00000000007fa4c1 in operator() (__closure=0x6000000ac1d8) at service/storage_proxy.cc:1399
#5  std::_Function_handler<void (), service::abstract_read_resolver::abstract_read_resolver(db::consistency_level, unsigned long, std::chrono::time_point<std::chrono::_V2::system_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > >)::{lambda()#1}>::_M_invoke(std::_Any_data const&) (__functor=...) at /usr/include/c++/4.9.2/functional:2039
#6  0x0000000000455ea3 in complete_timers<seastar::timer_set<timer<>, &timer<>::_link>, boost::intrusive::list<timer<>, boost::intrusive::member_hook<timer<>, boost::intrusive::list_member_hook<>, &timer<>::_link>, void, void>, reactor::run()::<lambda()>::<lambda()> > (this=<optimized out>, enable_fn=<optimized out>, expired_timers=..., timers=...) at core/reactor.hh:1114
#7  operator() (__closure=<optimized out>) at core/reactor.cc:1089
#8  std::_Function_handler<void(), reactor::run()::<lambda()> >::_M_invoke(const std::_Any_data &) (__functor=...) at /usr/include/c++/4.9.2/functional:2039
#9  0x00000000004421b4 in reactor::signals::poll_signal (this=0x6000001f7e18) at core/reactor.cc:171
#10 0x0000000000465521 in poll_once (this=0x6000001f7000) at core/reactor.cc:1168
#11 reactor::run (this=0x6000001f7000) at core/reactor.cc:1147
#12 0x00000000004adfbe in app_template::run(int, char**, std::function<void ()>&&) (this=this@entry=0x7fffffffd820, ac=ac@entry=9, av=av@entry=0x7fffffffda68, 
    func=func@entry=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x479acd, DIE 0x513cdd>) at core/app-template.cc:104
#13 0x0000000000419cf4 in main (ac=9, av=0x7fffffffda68) at main.cc:177
(gdb) c
Continuing.
Catchpoint 1 (exception thrown), __cxxabiv1::__cxa_throw (obj=0x6000000c84a0, tinfo=0xcad2b0 <typeinfo for exceptions::read_timeout_exception>, 
    dest=0x7e3b60 <exceptions::read_timeout_exception::~read_timeout_exception()>) at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:63
63    PROBE2 (throw, obj, tinfo);
(gdb) where
#0  __cxxabiv1::__cxa_throw (obj=0x6000000c84a0, tinfo=0xcad2b0 <typeinfo for exceptions::read_timeout_exception>, dest=0x7e3b60 <exceptions::read_timeout_exception::~read_timeout_exception()>)
    at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:63
#1  0x00000000007e8403 in std::make_exception_ptr<exceptions::read_timeout_exception> (__ex=...) at /usr/include/c++/4.9.2/bits/exception_ptr.h:174
#2  0x00000000007e8ecd in promise<foreign_ptr<lw_shared_ptr<query::result> > >::set_exception<exceptions::read_timeout_exception&> (this=0x60000010b618, e=...) at /home/shlomi/urchin/seastar/core/future.hh:439
#3  0x00000000007f966b in service::abstract_read_executor::execute(std::chrono::time_point<std::chrono::_V2::system_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > >)::{lambda(future<>)#2}::operator()(future<>) const (__closure=__closure@entry=0x600000112fb0, f=...) at service/storage_proxy.cc:1706
#4  0x00000000007f96d6 in futurize<void>::apply<service::abstract_read_executor::execute(std::chrono::time_point<std::chrono::_V2::system_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > >)::{lambda(future<>)#2}, future<> >(service::abstract_read_executor::execute(std::chrono::time_point<std::chrono::_V2::system_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > >)::{lambda(future<>)#2}&&, future<>&&) (func=func@entry=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x4df0309, DIE 0x514a483>) at /home/shlomi/urchin/seastar/core/future.hh:982
#5  0x00000000007fc544 in _ZZN6futureIIEE4thenIvZN7service22abstract_read_executor7executeENSt6chrono10time_pointINS4_3_V212system_clockENS4_8durationIlSt5ratioILl1ELl1000000000EEEEEEEUlS0_E0_ZNS0_12then_wrappedISD_S0_EET0_OT_EUlO12future_stateIIEEE_EEN8futurizeISG_E4typeEOSF_OT1_ENUlOT_E_clISJ_EEDaSH_ (__closure=0x600000112f90, state=<optimized out>) at /home/shlomi/urchin/seastar/core/future.hh:637
#6  0x0000000000441062 in reactor::run_tasks (this=this@entry=0x6000001f7000, tasks=..., quota=<optimized out>) at core/reactor.cc:1040
#7  0x00000000004654fb in reactor::run (this=0x6000001f7000) at core/reactor.cc:1137
#8  0x00000000004adfbe in app_template::run(int, char**, std::function<void ()>&&) (this=this@entry=0x7fffffffd820, ac=ac@entry=9, av=av@entry=0x7fffffffda68, 
    func=func@entry=<unknown type in /home/shlomi/urchin/build/release/scylla, CU 0x479acd, DIE 0x513cdd>) at core/app-template.cc:104
#9  0x0000000000419cf4 in main (ac=9, av=0x7fffffffda68) at main.cc:177

could it be that one of the adde features of glauber causes the create table to fail

[penberg]

I would put my money on d791438.

[slivne]

Its not the issue - I tested it and it is working ... I opened some bugs on
smp etc. but thats not the problem as to why simple create table on an
empty db does not work

its one of the patches that glauber has submitted for adding missing fields
to schema_columnfamilies

1. schema: memtable flush period (detail
   http://jenkins.cloudius-systems.com:8080/job/urchin-dtest/270/label=master/changes#detail0
   )
2. storage_proxy: move speculative_retry type to schema (detail
   http://jenkins.cloudius-systems.com:8080/job/urchin-dtest/270/label=master/changes#detail1
   )
3. schema: speculative retry (detail
   http://jenkins.cloudius-systems.com:8080/job/urchin-dtest/270/label=master/changes#detail2
   )
4. schema: support dropped columns (detail
   http://jenkins.cloudius-systems.com:8080/job/urchin-dtest/270/label=master/changes#detail3
   )

jenkins is what triggered me to check this

http://jenkins.cloudius-systems.com:8080/job/urchin-dtest/270/label=master/

all the tests are failing

I am double checking it now (moving back to
dce642f)

On Thu, Jul 30, 2015 at 10:37 AM, Pekka Enberg notifications@github.com
wrote:

I would put my money on d791438
d791438
.

—
Reply to this email directly or view it on GitHub
#57 (comment)
.

[penberg]

Well, it's perhaps possible that the newly added fields triggered an existing bug in sstable code. The prime suspect would then be 9887bc5 which uses the map data type.

[slivne]

just to reaffirm

with head at:

commit dce642f
Author: Avi Kivity avi@cloudius-systems.com
Date: Wed Jul 29 19:20:37 2015 +0300

commitlog: fix use-after-free of file during close

Reviewed-by: Nadav Har'El <nyh@cloudius-systems.com>

running

rm -Rf tmp/*; build/release/scylla --datadir tmp --commitlog-directory tmp --smp 1 --default-log-level info

this following works:

cqlsh> CREATE KEYSPACE keyspace3 WITH REPLICATION = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 };
cqlsh> CREATE TABLE keyspace3.standard1 ( key blob PRIMARY KEY, C0 blob, C1 blob, C2 blob, C3 blob, C4 blob);
cqlsh>

[tgrabiec]

The "no implemented" exception is thrown from create_table_from_table_row_and_column_rows():

        if (table_row.has("is_dense")) {
            is_dense = table_row.get_nonnull<bool>("is_dense");
        } else {
            // FIXME:
            // is_dense = CFMetaData.calculateIsDense(fullRawComparator, columnDefs);
            throw std::runtime_error("not implemented");
        }

#0  0x00007fbd4dd329f0 in __cxa_throw () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#1  0x000000000089d4be in db::legacy_schema_tables::create_table_from_table_row_and_column_rows (builder=..., table_row=..., serialized_column_definitions=...) at db/legacy_schema_tables.cc:1281
#2  0x000000000089dda2 in create_table_from_table_row_and_columns_partition (serialized_columns=..., table_row=..., builder=...) at db/legacy_schema_tables.cc:1207
#3  operator()<std::pair<const basic_sstring<char, unsigned int, 15u>, lw_shared_ptr<query::result_set> > > (serialized_columns=<error reading variable: access outside bounds of object referenced via synthetic pointer>, __closure=0x600000724810) at db/legacy_schema_tables.cc:1230
#4  apply (args=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x66c42c4>, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x66c42b2>) at /home/tgrabiec/src/urchin2/seastar/core/apply.hh:34
#5  apply<db::legacy_schema_tables::create_table_from_table_row(service::storage_proxy&, const query::result_set_row&)::<lambda(auto:47)>, std::pair<const basic_sstring<char, unsigned int, 15u>, lw_shared_ptr<query::result_set> > > (args=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b6ae4>, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b6ad0>) at /home/tgrabiec/src/urchin2/seastar/core/apply.hh:42
#6  apply<db::legacy_schema_tables::create_table_from_table_row(service::storage_proxy&, const query::result_set_row&)::<lambda(auto:47)>, std::pair<const basic_sstring<char, unsigned int, 15u>, lw_shared_ptr<query::result_set> > > (args=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x66c4292>, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x66c427f>) at /home/tgrabiec/src/urchin2/seastar/core/future.hh:953
#7  then<lw_shared_ptr<const schema>, db::legacy_schema_tables::create_table_from_table_row(service::storage_proxy&, const query::result_set_row&)::<lambda(auto:47)>, future<T>::then(Func&&) [with Func = db::legacy_schema_tables::create_table_from_table_row(service::storage_proxy&, const query::result_set_row&)::<lambda(auto:47)>; Result = future<lw_shared_ptr<const schema> >; T = {std::pair<const basic_sstring<char, unsigned int, 15u>, lw_shared_ptr<query::result_set> >}]::<lambda(future_state<std::pair<const basic_sstring<char, unsigned int, 15u>, lw_shared_ptr<query::result_set> > >&&)> > (param=<optimized out>, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b6c36>, this=0x6000007247e0) at /home/tgrabiec/src/urchin2/seastar/core/future.hh:625
#8  then<db::legacy_schema_tables::create_table_from_table_row(service::storage_proxy&, const query::result_set_row&)::<lambda(auto:47)>, future<lw_shared_ptr<const schema> > > (func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b7160>, this=0x6000007247e0) at /home/tgrabiec/src/urchin2/seastar/core/future.hh:758
#9  db::legacy_schema_tables::create_table_from_table_row (proxy=..., row=...) at db/legacy_schema_tables.cc:1232
#10 0x000000000089e83e in operator()<const query::result_set_row&> (row=..., __closure=0x600000724a60) at db/legacy_schema_tables.cc:1192
#11 parallel_for_each<__gnu_cxx::__normal_iterator<const query::result_set_row*, std::vector<query::result_set_row> >, db::legacy_schema_tables::create_tables_from_tables_partition(service::storage_proxy&, const mapped_type&)::<lambda(auto:46&&)> > (func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x66c6f50>, end=..., begin=...) at /home/tgrabiec/src/urchin2/seastar/core/future-util.hh:65
#12 db::legacy_schema_tables::create_tables_from_tables_partition (proxy=..., result=...) at db/legacy_schema_tables.cc:1194
#13 0x00000000008a0394 in _ZZZZN2db20legacy_schema_tables12merge_tablesERN7service13storage_proxyEOSt3mapI13basic_sstringIcjLj15EE13lw_shared_ptrIN5query10result_setEESt4lessIS6_ESaISt4pairIKS6_SA_EEESI_ENKUlRT_E_clISD_ISH_SH_EEEDaSK_ENKUlR8databaseE_clESP_ENKUlvE_clEv () at db/legacy_schema_tables.cc:660
#14 0x00000000008a11b5 in apply (args=<optimized out>, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b7556>) at /home/tgrabiec/src/urchin2/seastar/core/apply.hh:34
#15 apply<db::legacy_schema_tables::merge_tables(service::storage_proxy&, db::legacy_schema_tables::schema_result&&, db::legacy_schema_tables::schema_result&&)::<lambda(auto:43&)>::<lambda(database&)> [with auto:43 = std::pair<std::map<basic_sstring<char, unsigned int, 15u>, lw_shared_ptr<query::result_set> >, std::map<basic_sstring<char, unsigned int, 15u>, lw_shared_ptr<query::result_set> > >]::<lambda()> > (args=<optimized out>, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b7593>) at /home/tgrabiec/src/urchin2/seastar/core/apply.hh:42
#16 apply<db::legacy_schema_tables::merge_tables(service::storage_proxy&, db::legacy_schema_tables::schema_result&&, db::legacy_schema_tables::schema_result&&)::<lambda(auto:43&)>::<lambda(database&)> [with auto:43 = std::pair<std::map<basic_sstring<char, unsigned int, 15u>, lw_shared_ptr<query::result_set> >, std::map<basic_sstring<char, unsigned int, 15u>, lw_shared_ptr<query::result_set> > >]::<lambda()> > (args=<optimized out>, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b75d3>) at /home/tgrabiec/src/urchin2/seastar/core/future.hh:972
#17 operator() (__closure=<optimized out>) at /home/tgrabiec/src/urchin2/seastar/core/thread.hh:197
#18 std::_Function_handler<void(), seastar::async(Func&&, Args&& ...)::<lambda(seastar::async(Func&&, Args&& ...)::work&)> [with Func = db::legacy_schema_tables::merge_tables(service::storage_proxy&, db::legacy_schema_tables::schema_result&&, db::legacy_schema_tables::schema_result&&)::<lambda(auto:43&)>::<lambda(database&)> [with auto:43 = std::pair<std::map<basic_sstring<char, unsigned int, 15u>, lw_shared_ptr<query::result_set> >, std::map<basic_sstring<char, unsigned int, 15u>, lw_shared_ptr<query::result_set> > >]::<lambda()>; Args = {}]::<lambda()> >::_M_invoke(const std::_Any_data &) (__functor=...) at /usr/include/c++/4.9/functional:2039
#19 0x0000000000418bb6 in operator() (this=0x600000118e08) at /usr/include/c++/4.9/functional:2439
#20 seastar::thread_context::main (this=0x600000118e00) at core/thread.cc:89
#21 0x00000000004b2052 in seastar::thread_context::s_main (lo=<optimized out>, hi=<optimized out>) at core/thread.cc:83

The row is missing a cell for is_dense, but not only, it misses other columns too.

$2 = (const query::result_set_row &) @0x6000006dbd20: {_schema = {_p = 0x60000009cc80}, _cells = std::unordered_map with 11 elements = {[{u = {external = {str = 0x746e656d6d6f63 <error: Cannot access memory at address 0x746e656d6d6f63>, size = 0x2ab0f0, pad = 0x0}, internal = {str = "comment\000\360\260*\000\000`", size = 0x7}}, static npos = 0xffffffff}] = {_value = {content = 0x0}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}, [{u = {external = {str = 0x6000007625a0 "compaction_strategy_class", size = 0x19, pad = 0x63}, internal = {str = "\240%v\000\000`\000\000\031\000\000\000cas", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006b0b98}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}, [{u = {external = {str = 0x6000006b0b44 "compression_parameters", size = 0x16, pad = 0x0}, internal = {str = "D\vk\000\000`\000\000\026\000\000\000\000`", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006b0f50}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}, [{u = {external = {str = 0x11000064695f6663 <error: Cannot access memory at address 0x11000064695f6663>, size = 0x2aaf90, pad = 0x0}, internal = {str = "cf_id\000\000\021\220\257*\000\000`", size = 0x5}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006f2d20}, _type = {_b = 0x6000000e1e00, _p = 0x6000000e1e00}}, [{u = {external = {str = 0x74617261706d6f63 <error: Cannot access memory at address 0x74617261706d6f63>, size = 0x726f, pad = 0x0}, internal = {str = "comparator\000\000\000`", size = 0xa}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006b0834}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}, [{u = {external = {str = 0x6000006b0f6c "bloom_filter_fp_chance", size = 0x16, pad = 0x0}, internal = {str = "l\017k\000\000`\000\000\026\000\000\000\000\000", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006f6260}, _type = {_b = 0x6000000e1d40, _p = 0x6000000e1d40}}, [{u = {external = {str = 0x6000006f2bec "default_time_to_live", size = 0x14, pad = 0x11}, internal = {str = "\354+o\000\000`\000\000\024\000\000\000\021\000", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000000a9070}, _type = {_b = 0x6000000e1fa0, _p = 0x6000000e1fa0}}, [{u = {external = {str = 0x6000006f2000 "default_validator", size = 0x11, pad = 0x11}, internal = {str = "\000 o\000\000`\000\000\021\000\000\000\021\000", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006f2118}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}, [{u = {external = {str = 0x600000762560 "compaction_strategy_options", size = 0x1b, pad = 0x63}, internal = {str = "`%v\000\000`\000\000\033\000\000\000cas", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006f25cc}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}, [{u = {external = {str = 0x656361707379656b <error: Cannot access memory at address 0x656361707379656b>, size = 0x6d616e5f, pad = 0x65}, internal = {str = "keyspace_name\000", size = 0xd}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006b0e00}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}, [{u = {external = {str = 0x600000687054 "columnfamily_name", size = 0x11, pad = 0x0}, internal = {str = "Tph\000\000`\000\000\021\000\000\000\000`", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006f2bb4}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}}}

[slivne]

If its simple to fix - lets fix it - if not lets roll back and wait for
glauber to fix it ... he will be up in 3-4 hours

On Thu, Jul 30, 2015 at 11:39 AM, Tomasz Grabiec notifications@github.com
wrote:

The "no implemented" exception is thrown from
create_table_from_table_row_and_column_rows():

    if (table_row.has("is_dense")) {
        is_dense = table_row.get_nonnull<bool>("is_dense");
    } else {
        // FIXME:
        // is_dense = CFMetaData.calculateIsDense(fullRawComparator, columnDefs);
        throw std::runtime_error("not implemented");
    }

#0 0x00007fbd4dd329f0 in __cxa_throw () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#1 0x000000000089d4be in db::legacy_schema_tables::create_table_from_table_row_and_column_rows (builder=..., table_row=..., serialized_column_definitions=...) at db/legacy_schema_tables.cc:1281
#2 0x000000000089dda2 in create_table_from_table_row_and_columns_partition (serialized_columns=..., table_row=..., builder=...) at db/legacy_schema_tables.cc:1207
#3 operator()<std::pair<const basic_sstring<char, unsigned int, 15u>, lw_shared_ptrquery::result_set > > (serialized_columns=, __closure=0x600000724810) at db/legacy_schema_tables.cc:1230
#4 apply (args=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x66c42c4>, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x66c42b2>) at /home/tgrabiec/src/urchin2/seastar/core/apply.hh:34
#5 apply<db::legacy_schema_tables::create_table_from_table_row(service::storage_proxy&, const query::result_set_row&)::<lambda(auto:47)>, std::pair<const basic_sstring<char, unsigned int, 15u>, lw_shared_ptrquery::result_set > > (args=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b6ae4>, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b6ad0>) at /home/tgrabiec/src/urchin2/seastar/core/apply.hh:42
#6 apply<db::legacy_schema_tables::create_table_from_table_row(service::storage_proxy&, const query::result_set_row&)::<lambda(auto:47)>, std::pair<const basic_sstring<char, unsigned int, 15u>, lw_shared_ptrquery::result_set > > (args=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x66c4292>, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x66c427f>) at /home/tgrabiec/src/urchin2/seastar/core/future.hh:953
#7 then<lw_shared_ptr, db::legacy_schema_tables::create_table_from_table_row(service::storage_proxy&, const query::result_set_row&)::<lambda(auto:47)>, future::then(Func&&) [with Func = db::legacy_schema_tables::create_table_from_table_row(service::storage_proxy&, const query::result_set_row&)::<lambda(auto:47)>; Result = future<lw_shared_ptr >; T = {std::pair<const basic_sstring<char, unsigned int, 15u>, lw_shared_ptrquery::result_set >}]::<lambda(future_state<std::pair<const basic_sstring<char, unsigned int, 15u>, lw_shared_ptrquery::result_set > >&&)> > (param=, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b6c36>, this=0x6000007247e0) at /home/tgrabiec/src/urchin2/seastar/core/future.hh:625
#8 then<db::legacy_schema_tables::create_table_from_table_row(service::storage_proxy&, const query::result_set_row&)::<lambda(auto:47)>, future<lw_shared_ptr > > (func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b7160>, this=0x6000007247e0) at /home/tgrabiec/src/urchin2/seastar/core/future.hh:758
#9 db::legacy_schema_tables::create_table_from_table_row (proxy=..., row=...) at db/legacy_schema_tables.cc:1232
#10 0x000000000089e83e in operator()<const query::result_set_row&> (row=..., __closure=0x600000724a60) at db/legacy_schema_tables.cc:1192
#11 parallel_for_each<__gnu_cxx::__normal_iterator<const query::result_set_row*, std::vectorquery::result_set_row >, db::legacy_schema_tables::create_tables_from_tables_partition(service::storage_proxy&, const mapped_type&)::<lambda(auto:46&&)> > (func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x66c6f50>, end=..., begin=...) at /home/tgrabiec/src/urchin2/seastar/core/future-util.hh:65
#12 db::legacy_schema_tables::create_tables_from_tables_partition (proxy=..., result=...) at db/legacy_schema_tables.cc:1194
#13 0x00000000008a0394 in _ZZZZN2db20legacy_schema_tables12merge_tablesERN7service13storage_proxyEOSt3mapI13basic_sstringIcjLj15EE13lw_shared_ptrIN5query10result_setEESt4lessIS6_ESaISt4pairIKS6_SA_EEESI_ENKUlRT_E_clISD_ISH_SH_EEEDaSK_ENKUlR8databaseE_clESP_ENKUlvE_clEv () at db/legacy_schema_tables.cc:660
#14 0x00000000008a11b5 in apply (args=, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b7556>) at /home/tgrabiec/src/urchin2/seastar/core/apply.hh:34
#15 apply<db::legacy_schema_tables::merge_tables(service::storage_proxy&, db::legacy_schema_tables::schema_result&&, db::legacy_schema_tables::schema_result&&)::<lambda(auto:43&)>::<lambda(database&)> [with auto:43 = std::pair<std::map<basic_sstring<char, unsigned int, 15u>, lw_shared_ptrquery::result_set >, std::map<basic_sstring<char, unsigned int, 15u>, lw_shared_ptrquery::result_set > >]::<lambda()> > (args=, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b7593>) at /home/tgrabiec/src/urchin2/seastar/core/apply.hh:42
#16 apply<db::legacy_schema_tables::merge_tables(service::storage_proxy&, db::legacy_schema_tables::schema_result&&, db::legacy_schema_tables::schema_result&&)::<lambda(auto:43&)>::<lambda(database&)> [with auto:43 = std::pair<std::map<basic_sstring<char, unsigned int, 15u>, lw_shared_ptrquery::result_set >, std::map<basic_sstring<char, unsigned int, 15u>, lw_shared_ptrquery::result_set > >]::<lambda()> > (args=, func=<unknown type in /home/tgrabiec/src/urchin2/build/release/scylla, CU 0x63de22a, DIE 0x65b75d3>) at /home/tgrabiec/src/urchin2/seastar/core/future.hh:972
#17 operator() (__closure=) at /home/tgrabiec/src/urchin2/seastar/core/thread.hh:197
#18 std::_Function_handler<void(), seastar::async(Func&&, Args&& ...)::<lambda(seastar::async(Func&&, Args&& ...)::work&)> [with Func = db::legacy_schema_tables::merge_tables(service::storage_proxy&, db::legacy_schema_tables::schema_result&&, db::legacy_schema_tables::schema_result&&)::<lambda(auto:43&)>::<lambda(database&)> [with auto:43 = std::pair<std::map<basic_sstring<char, unsigned int, 15u>, lw_shared_ptrquery::result_set >, std::map<basic_sstring<char, unsigned int, 15u>, lw_shared_ptrquery::result_set > >]::<lambda()>; Args = {}]::<lambda()> >::_M_invoke(const std::_Any_data &) (__functor=...) at /usr/include/c++/4.9/functional:2039
#19 0x0000000000418bb6 in operator() (this=0x600000118e08) at /usr/include/c++/4.9/functional:2439
#20 seastar::thread_context::main (this=0x600000118e00) at core/thread.cc:89
#21 0x00000000004b2052 in seastar::thread_context::s_main (lo=, hi=) at core/thread.cc:83

The row is missing a cell for is_dense, but not only, it misses other
columns too.

$2 = (const query::result_set_row &) @0x6000006dbd20: {_schema = {_p = 0x60000009cc80}, cells = std::unordered_map with 11 elements = {[{u = {external = {str = 0x746e656d6d6f63 <error: Cannot access memory at address 0x746e656d6d6f63>, size = 0x2ab0f0, pad = 0x0}, internal = {str = "comment\000\360\260\000\000", size = 0x7}}, static npos = 0xffffffff}] = {_value = {content = 0x0}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}, [{u = {external = {str = 0x6000007625a0 "compaction_strategy_class", size = 0x19, pad = 0x63}, internal = {str = "\240%v\000\000\000\000\031\000\000\000cas", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006b0b98}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}, [{u = {external = {str = 0x6000006b0b44 "compression_parameters", size = 0x16, pad = 0x0}, internal = {str = "D\vk\000\000\000\000\026\000\000\000\000", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006b0f50}, _type
= {_b = 0x600000316f40, p = 0x600000316f40}}, [{u = {external = {str = 0x11000064695f6663 <error: Cannot access memory at address 0x11000064695f6663>, size = 0x2aaf90, pad = 0x0}, internal = {str = "cf_id\000\000\021\220\257\000\000", size = 0x5}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006f2d20}, _type = {_b = 0x6000000e1e00, _p = 0x6000000e1e00}}, [{u = {external = {str = 0x74617261706d6f63 <error: Cannot access memory at address 0x74617261706d6f63>, size = 0x726f, pad = 0x0}, internal = {str = "comparator\000\000\000", size = 0xa}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006b0834}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}, [{u = {external = {str = 0x6000006b0f6c "bloom_filter_fp_chance", size = 0x16, pad = 0x0}, internal = {str = "l\017k\000\000\000\000\026\000\000\000\000\000", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006f6260}, _type = {_b = 0x6000000e1d40, _p = 0x6000000e1d40}}, [{u = { external = {str = 0x6000006f2bec "default_time_to_live", size = 0x14, pad = 0x11}, internal = {str = "\354+o\000\000\000\000\024\000\000\000\021\000", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000000a9070}, _type = {_b = 0x6000000e1fa0, _p = 0x6000000e1fa0}}, [{u = {external = {str = 0x6000006f2000 "default_validator", size = 0x11, pad = 0x11}, internal = {str = "\000 o\000\000\000\000\021\000\000\000\021\000", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006f2118}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}, [{u = {external = {str = 0x600000762560 "compaction_strategy_options", size = 0x1b, pad = 0x63}, internal = {str = "%v\000\000\000\000\033\000\000\000cas", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006f25cc}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}, [{u = {external = {str = 0x656361707379656b <error: Cannot access memory at address 0x656361707379656b>, size = 0x6d616e 5f, pad = 0x65}, internal = {str = "keyspace_name\000", size = 0xd}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006b0e00}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}, [{u = {external = {str = 0x600000687054 "columnfamily_name", size = 0x11, pad = 0x0}, internal = {str = "Tph\000\000\000\000\021\000\000\000\000`", size = 0xff}}, static npos = 0xffffffff}] = {_value = {content = 0x6000006f2bb4}, _type = {_b = 0x600000316f40, _p = 0x600000316f40}}}}

—
Reply to this email directly or view it on GitHub
#57 (comment)
.

[penberg]

@slivne, fixed by c68c37a. Please close.

[glommer]

There is good info here, because there are example queries.
I will resubmit the patch once I find the problem.