Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support command line options api-address, api-port, api-dir from yaml file #59

Closed
slivne opened this issue Jul 30, 2015 · 4 comments
Closed

support command line options api-address, api-port, api-dir from yaml file #59

slivne opened this issue Jul 30, 2015 · 4 comments
Labels
bug
Milestone
anglerfish - scyl...

Comments

@slivne
Copy link
Contributor

slivne commented Jul 30, 2015

No description provided.

@slivne slivne added the bug label Jul 30, 2015
@slivne slivne added this to the Beta milestone Jul 30, 2015
@slivne slivne mentioned this issue Aug 10, 2015
Closed
@slivne slivne added the ready label Aug 27, 2015
@slivne
Copy link
Contributor Author

slivne commented Aug 30, 2015

@avikivity please roll back this patchset - it is not working

using the head

commit 5aa0244
Merge: 7fb109a 800578f
Author: Avi Kivity avi@cloudius-systems.com
Date: Sat Aug 29 12:34:04 2015 +0300

Merge "Move the API configuration from command line to configuration"

from Amnon

"This series address issues #59 and #23.

It moves the API configuration from the command line argument to the

general
config, it also move the api-doc directory to be configurable instead
of hard
coded."

Fixes #59
Fixes #23

when running with api-address it is crashing, removing the flag it works

shlomi@localhost~/urchin (master)$ rm -Rf tmp/; build/debug/scylla
--datadir pwd/tmp --commitlog-directory pwd/tmp *--api-address
127.0.0.1

WARNING: debug mode. Not for benchmarking or production

==6475==ERROR: AddressSanitizer: stack-buffer-overflow on address
0x7ffee04b8350 at pc 0x551788 bp 0x7ffee04b8100 sp 0x7ffee04b80f0
READ of size 8 at 0x7ffee04b8350 thread T0
#0 0x551787 in std::_Rb_tree<std::string, std::pair<std::string const,
std::string>, std::_Select1st<std::pair<std::string const, std::string> >,
std::lessstd::string, std::allocator<std::pair<std::string const,
std::string> > >::_M_begin() /usr/include/c++/4.9.2/bits/stl_tree.h:518
#1 0x586458 in std::_Rb_tree<std::string, std::pair<std::string const,
std::string>, std::_Select1st<std::pair<std::string const, std::string> >,
std::lessstd::string, std::allocator<std::pair<std::string const,
std::string> > >::lower_bound(std::string const&)
/usr/include/c++/4.9.2/bits/stl_tree.h:927
#2 0x55193e in std::map<std::string, std::string,
std::lessstd::string, std::allocator<std::pair<std::string const,
std::string> > >::lower_bound(std::string const&)
/usr/include/c++/4.9.2/bits/stl_map.h:902
#3 0x52ed6e in std::map<std::string, std::string,
std::lessstd::string, std::allocator<std::pair<std::string const,
std::string> > >::operator[](std::string const&)
/usr/include/c++/4.9.2/bits/stl_map.h:496
#4 0x3c1205373f in
boost::program_options::error_with_option_name::substitute_placeholders(std::string
const&) const (/lib64/libboost_program_options.so.1.55.0+0x3c1205373f)
#5 0x3c120525ed in
boost::program_options::error_with_option_name::what() const
(/lib64/libboost_program_options.so.1.55.0+0x3c120525ed)
#6 0x7264fb in app_template::run_deprecated(int, char**,
std::function<void ()>&&) core/app-template.cc:100
#7 0xa1a182 in main /home/shlomi/urchin/main.cc:210
#8 0x3c0d01ffdf in __libc_start_main (/lib64/libc.so.6+0x3c0d01ffdf)
#9 0x412018 (/home/shlomi/urchin/build/debug/scylla+0x412018)

On Sat, Aug 29, 2015 at 12:35 PM, Avi Kivity notifications@github.com
wrote:

Closed #59 #59 via
5aa0244
5aa0244
.

—
Reply to this email directly or view it on GitHub
#59 (comment).

@slivne
Copy link
Contributor Author

slivne commented Aug 30, 2015

@avikivity - this is failing all the dtests ... so we need this rolled back
to have any dtest testing.

On Sun, Aug 30, 2015 at 10:42 AM, Shlomi Livne shlomi@cloudius-systems.com
wrote:

@avikivity please roll back this patchset - it is not working

using the head

commit 5aa0244
Merge: 7fb109a 800578f
Author: Avi Kivity avi@cloudius-systems.com
Date: Sat Aug 29 12:34:04 2015 +0300

Merge "Move the API configuration from command line to configuration"

from Amnon

"This series address issues #59 and #23.

It moves the API configuration from the command line argument to the

general
config, it also move the api-doc directory to be configurable instead
of hard
coded."

Fixes #59
Fixes #23

when running with api-address it is crashing, removing the flag it works

shlomi@localhost~/urchin (master)$ rm -Rf tmp/; build/debug/scylla
--datadir pwd/tmp --commitlog-directory pwd/tmp *--api-address
127.0.0.1

WARNING: debug mode. Not for benchmarking or production

==6475==ERROR: AddressSanitizer: stack-buffer-overflow on address
0x7ffee04b8350 at pc 0x551788 bp 0x7ffee04b8100 sp 0x7ffee04b80f0
READ of size 8 at 0x7ffee04b8350 thread T0
#0 0x551787 in std::_Rb_tree<std::string, std::pair<std::string const,
std::string>, std::_Select1st<std::pair<std::string const, std::string> >,
std::lessstd::string, std::allocator<std::pair<std::string const,
std::string> > >::_M_begin() /usr/include/c++/4.9.2/bits/stl_tree.h:518
#1 0x586458 in std::_Rb_tree<std::string, std::pair<std::string const,
std::string>, std::_Select1st<std::pair<std::string const, std::string> >,
std::lessstd::string, std::allocator<std::pair<std::string const,
std::string> > >::lower_bound(std::string const&)
/usr/include/c++/4.9.2/bits/stl_tree.h:927
#2 0x55193e in std::map<std::string, std::string,
std::lessstd::string, std::allocator<std::pair<std::string const,
std::string> > >::lower_bound(std::string const&)
/usr/include/c++/4.9.2/bits/stl_map.h:902
#3 0x52ed6e in std::map<std::string, std::string,
std::lessstd::string, std::allocator<std::pair<std::string const,
std::string> > >::operator[](std::string const&)
/usr/include/c++/4.9.2/bits/stl_map.h:496
#4 0x3c1205373f in
boost::program_options::error_with_option_name::substitute_placeholders(std::string
const&) const (/lib64/libboost_program_options.so.1.55.0+0x3c1205373f)
#5 0x3c120525ed in
boost::program_options::error_with_option_name::what() const
(/lib64/libboost_program_options.so.1.55.0+0x3c120525ed)
#6 0x7264fb in app_template::run_deprecated(int, char**,
std::function<void ()>&&) core/app-template.cc:100
#7 0xa1a182 in main /home/shlomi/urchin/main.cc:210
#8 0x3c0d01ffdf in __libc_start_main (/lib64/libc.so.6+0x3c0d01ffdf)
#9 0x412018 (/home/shlomi/urchin/build/debug/scylla+0x412018)

On Sat, Aug 29, 2015 at 12:35 PM, Avi Kivity notifications@github.com
wrote:

Closed #59 #59 via
5aa0244
5aa0244
.

—
Reply to this email directly or view it on GitHub
#59 (comment).

avikivity added a commit that referenced this issue Aug 30, 2015
@avikivity
Revert "Merge "Move the API configuration from command line to config…
554645d 
…uration" from Amnon"

See issue #59 for details.

This reverts commit 5aa0244, reversing
changes made to 7fb109a.
@amnonh
Copy link
Contributor

amnonh commented Aug 30, 2015

I see that I misspelled api-address (there's a missing s) that's why it
doesn't work
I'll handle it when I'm back.

On Sun, Aug 30, 2015 at 10:42 AM, slivne notifications@github.com wrote:

@avikivity please roll back this patchset - it is not working

using the head

commit 5aa0244
Merge: 7fb109a 800578f
Author: Avi Kivity avi@cloudius-systems.com
Date: Sat Aug 29 12:34:04 2015 +0300

Merge "Move the API configuration from command line to configuration"
from Amnon

"This series address issues #59 and #23.

It moves the API configuration from the command line argument to the
general
config, it also move the api-doc directory to be configurable instead
of hard
coded."

Fixes #59
Fixes #23

when running with api-address it is crashing, removing the flag it works

shlomi@localhost~/urchin (master)$ rm -Rf tmp/; build/debug/scylla
--datadir pwd/tmp --commitlog-directory pwd/tmp *--api-address
127.0.0.1

WARNING: debug mode. Not for benchmarking or production

==6475==ERROR: AddressSanitizer: stack-buffer-overflow on address
0x7ffee04b8350 at pc 0x551788 bp 0x7ffee04b8100 sp 0x7ffee04b80f0
READ of size 8 at 0x7ffee04b8350 thread T0
#0 0x551787 in std::_Rb_tree<std::string, std::pair<std::string const,
std::string>, std::_Select1st<std::pair<std::string const, std::string> >,
std::lessstd::string, std::allocator<std::pair<std::string const,
std::string> > >::_M_begin() /usr/include/c++/4.9.2/bits/stl_tree.h:518
#1 0x586458 in std::_Rb_tree<std::string, std::pair<std::string const,
std::string>, std::_Select1st<std::pair<std::string const, std::string> >,
std::lessstd::string, std::allocator<std::pair<std::string const,
std::string> > >::lower_bound(std::string const&)
/usr/include/c++/4.9.2/bits/stl_tree.h:927
#2 0x55193e in std::map<std::string, std::string,
std::lessstd::string, std::allocator<std::pair<std::string const,
std::string> > >::lower_bound(std::string const&)
/usr/include/c++/4.9.2/bits/stl_map.h:902
#3 0x52ed6e in std::map<std::string, std::string,
std::lessstd::string, std::allocator<std::pair<std::string const,
std::string> > >::operator[](std::string const&)
/usr/include/c++/4.9.2/bits/stl_map.h:496
#4 0x3c1205373f in

boost::program_options::error_with_option_name::substitute_placeholders(std::string
const&) const (/lib64/libboost_program_options.so.1.55.0+0x3c1205373f)
#5 0x3c120525ed in
boost::program_options::error_with_option_name::what() const
(/lib64/libboost_program_options.so.1.55.0+0x3c120525ed)
#6 0x7264fb in app_template::run_deprecated(int, char**,
std::function<void ()>&&) core/app-template.cc:100
#7 0xa1a182 in main /home/shlomi/urchin/main.cc:210
#8 0x3c0d01ffdf in __libc_start_main (/lib64/libc.so.6+0x3c0d01ffdf)
#9 0x412018 (/home/shlomi/urchin/build/debug/scylla+0x412018)

On Sat, Aug 29, 2015 at 12:35 PM, Avi Kivity notifications@github.com
wrote:

Closed #59 #59 via
5aa0244
<
5aa0244

.

—
Reply to this email directly or view it on GitHub
#59 (comment).

—
Reply to this email directly or view it on GitHub
#59 (comment)
.

@avikivity avikivity reopened this Aug 30, 2015
@slivne
Copy link
Contributor Author

slivne commented Sep 18, 2015

they have been mode to config closing

@slivne slivne closed this as completed Sep 18, 2015
@nirmaayan nirmaayan mentioned this issue Aug 1, 2016
Closed
@jinxing64 jinxing64 mentioned this issue Sep 27, 2016
Closed
@GpStore GpStore mentioned this issue Nov 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
anglerfish - scylla 0.9
Development

No branches or pull requests
3 participants
@avikivity @amnonh @slivne