Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system.clients is missing information with regards to connected clients #6946

Closed
slivne opened this issue Jul 28, 2020 · 11 comments
Closed

system.clients is missing information with regards to connected clients #6946

slivne opened this issue Jul 28, 2020 · 11 comments
Labels
area/monitoring tracing type/bug
Milestone
4.6

Comments

@slivne
Copy link
Contributor

slivne commented Jul 28, 2020

Scylla 4.0.X

cat /etc/scylla/scylla.yaml  | grep ^auth
authenticator: PasswordAuthenticator
authorizer: CassandraAuthorizer

[root@e40a07114766 /]# cqlsh -u cassandra -p cassandra
Connected to  at 172.17.0.3:9042.
[cqlsh 5.0.1 | Cassandra 3.0.8 | CQL spec 3.3.1 | Native protocol v4]
Use HELP for help.
cassandra@cqlsh> select * from system.clients ;

 address    | port  | client_type | connection_stage | driver_name | driver_version | hostname | protocol_version | shard_id | ssl_cipher_suite | ssl_enabled | ssl_protocol | username
------------+-------+-------------+------------------+-------------+----------------+----------+------------------+----------+------------------+-------------+--------------+-----------
 172.17.0.3 | 60618 |         cql |             null |        null |           null |     null |                0 |        0 |             null |        null |         null | anonymous
 172.17.0.3 | 60620 |         cql |             null |        null |           null |     null |                0 |        1 |             null |        null |         null | anonymous
  • too many fields are null all of them should have values.
  • username is incorrect its anonymous it should be cassandra
  • protocol version is incorrect its not version 0
@slivne slivne added this to the 4.3 milestone Jul 28, 2020
@jul-stas jul-stas mentioned this issue Oct 6, 2020
Merged
avikivity added a commit that referenced this issue Oct 27, 2020
@avikivity
Merge 'transport/system_ks: Add more info to system.clients' from J…
fb24bcc 
…uliusz Stasiewicz

This patch fills the following columns in `system.clients` table:
* `connection_stage`
* `driver_name`
* `driver_version`
* `protocol_version`

It also improves:
* `client_type` - distinguishes cql from thrift just in case
* `username` - now it displays correct username iff `PasswordAuthenticator` is configured.

What is still missing:
* SSL params (I'll happily get some advice here)
* `hostname` - I didn't find it in tested drivers

Refs #6946

Closes #7349

* github.com:scylladb/scylla:
  transport: Update `connection_stage` in `system.clients`
  transport: Retrieve driver's name and version from STARTUP message
  transport: Notify `system.clients` about "protocol_version"
  transport: On successful authentication add `username` to system.clients
avikivity added a commit that referenced this issue Oct 27, 2020
@avikivity
Merge 'transport/system_ks: Add more info to system.clients' from J…
aa011cf 
…uliusz Stasiewicz

This patch fills the following columns in `system.clients` table:
* `connection_stage`
* `driver_name`
* `driver_version`
* `protocol_version`

It also improves:
* `client_type` - distinguishes cql from thrift just in case
* `username` - now it displays correct username iff `PasswordAuthenticator` is configured.

What is still missing:
* SSL params (I'll happily get some advice here)
* `hostname` - I didn't find it in tested drivers

Refs #6946

Closes #7349

* github.com:scylladb/scylla:
  transport: Update `connection_stage` in `system.clients`
  transport: Retrieve driver's name and version from STARTUP message
  transport: Notify `system.clients` about "protocol_version"
  transport: On successful authentication add `username` to system.clients
avikivity added a commit that referenced this issue Oct 27, 2020
@avikivity
Merge 'transport/system_ks: Add more info to system.clients' from J…
e2a02f1 
…uliusz Stasiewicz

This patch fills the following columns in `system.clients` table:
* `connection_stage`
* `driver_name`
* `driver_version`
* `protocol_version`

It also improves:
* `client_type` - distinguishes cql from thrift just in case
* `username` - now it displays correct username iff `PasswordAuthenticator` is configured.

What is still missing:
* SSL params (I'll happily get some advice here)
* `hostname` - I didn't find it in tested drivers

Refs #6946

Closes #7349

* github.com:scylladb/scylla:
  transport: Update `connection_stage` in `system.clients`
  transport: Retrieve driver's name and version from STARTUP message
  transport: Notify `system.clients` about "protocol_version"
  transport: On successful authentication add `username` to system.clients
@tzach
Copy link
Contributor

tzach commented Jan 19, 2021

@amnonh we can include this info in the connect table in the monitoring dashboard

@haaawk haaawk removed their assignment Feb 3, 2021
@haaawk
Copy link
Contributor

haaawk commented Feb 3, 2021

Can we close this already @jul-stas ?

@jul-stas
Copy link
Contributor

jul-stas commented Feb 3, 2021 •
edited

The encryption info is missing and the last time I talked to @elcallio (> year ago) I learned that it's not trivial to get this info. We can give it a try, but I'm not proficient with crypto unless I'll have to be.
EDIT: No, we can't.

@haaawk haaawk assigned haaawk and unassigned jul-stas Mar 21, 2021
@slivne slivne modified the milestones: 4.3, 4.x Mar 29, 2021
@slivne
Copy link
Contributor Author

slivne commented Mar 29, 2021

Aside of encryption and hostname all should be populated if this is not the case open a bug.

pushing these based on requests

@jul-stas
Copy link
Contributor

I'm closing this in favor of this: #9216

@avikivity
Copy link
Member

Usually it's better to close the new bugs, to preserve the historical record.

@avikivity
Copy link
Member

And it's not possible to backport issues that have no commits attached.

@jul-stas
Copy link
Contributor

I edited #7349 by adding "Fixes #6946", but apparently it didn't work (too late?)
What can I do instead?

@avikivity
Copy link
Member

Ah, then add "Fixed by <commit_hash> here, and add the backport candidate label (mimicking what the robots would do if you added the Fixes # thing in time).

@jul-stas
Copy link
Contributor

Fixed by fb24bcc
Note: needs backporting to 2020 and 2021

benipeled pushed a commit to benipeled/scylla that referenced this issue May 31, 2022
@avikivity
Merge 'transport/system_ks: Add more info to system.clients' from J…
698012f 
…uliusz Stasiewicz

This patch fills the following columns in `system.clients` table:
* `connection_stage`
* `driver_name`
* `driver_version`
* `protocol_version`

It also improves:
* `client_type` - distinguishes cql from thrift just in case
* `username` - now it displays correct username iff `PasswordAuthenticator` is configured.

What is still missing:
* SSL params (I'll happily get some advice here)
* `hostname` - I didn't find it in tested drivers

Refs scylladb#6946

Closes scylladb#7349

* github.com:scylladb/scylla:
  transport: Update `connection_stage` in `system.clients`
  transport: Retrieve driver's name and version from STARTUP message
  transport: Notify `system.clients` about "protocol_version"
  transport: On successful authentication add `username` to system.clients

(cherry picked from commit e2a02f1)

Closes scylladb#1958

Ref scylladb#1953.
@avikivity
Copy link
Member

Not a bug, not backporting.

@DoronArazii DoronArazii modified the milestones: 5.x, 4.6 Jul 14, 2022
@mykaul mykaul mentioned this issue Oct 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/monitoring tracing type/bug
Projects
None yet
Milestone
4.6
Development

No branches or pull requests
6 participants
@tzach @avikivity @haaawk @slivne @jul-stas @DoronArazii