-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache will accumelate range tombstones for sstables when large row/parition/cell exist - lets not allow this #7750
Comments
reference from cdc log e3dd78b |
In what way is this a bug? If you report a bug, explain what is wrong with the system. If you suggest an enhancement, explain how it will make the system better. |
@bhalevy ping lets get this fix sent and merged |
Cache will accumelate range tombsones for sstables holding large partition/row/cell - we will be imporiving the range tombstone management (by changing their represtnation) but till we do so - lets make sure that range tombstones for system.large_XXX are not accumulated by disabling caching of those tables. |
@bhalevy please queue this in the workplan as well |
The cache of system.large_{partition,rows,cells} accumulates range tombstones (#7750), and those range tombstones can be evicted only together with their partition (#3288). Making the system.large_* tables uncached should work around the problem until #3288 is fixed. Fixes #8874 Refs #7750 Refs #3288 Signed-off-by: Michael Livshin <michael.livshin@scylladb.com> Message-Id: <20210623171932.8837-1-michael.livshin@scylladb.com>
The cache of system.large_{partition,rows,cells} accumulates range tombstones (scylladb#7750), and those range tombstones can be evicted only together with their partition (scylladb#3288). Making the system.large_* tables uncached should work around the problem until scylladb#3288 is fixed. Fixes scylladb#8874 Refs scylladb#7750 Refs scylladb#3288 Signed-off-by: Michael Livshin <michael.livshin@scylladb.com> Message-Id: <20210623171932.8837-1-michael.livshin@scylladb.com>
I created new issues for each missing field in DescribeTable's response for GSIs and LSIs, so in this patch we edit the xfail messages in the test to refer to these issues. Additionally, we only had a test for these fields for GSIs, so this patch also adds a similar test for LSIs. I turns out there is a difference between the two tests - the two fields IndexStatus and ProvisionedThroughput are returned for GSIs, but not for LSIs. Refs scylladb#7750 Refs scylladb#11466 Refs scylladb#11470 Refs scylladb#11471 Signed-off-by: Nadav Har'El <nyh@scylladb.com>
I created new issues for each missing field in DescribeTable's response for GSIs and LSIs, so in this patch we edit the xfail messages in the test to refer to these issues. Additionally, we only had a test for these fields for GSIs, so this patch also adds a similar test for LSIs. I turns out there is a difference between the two tests - the two fields IndexStatus and ProvisionedThroughput are returned for GSIs, but not for LSIs. Refs #7750 Refs #11466 Refs #11470 Refs #11471 Signed-off-by: Nadav Har'El <nyh@scylladb.com> Closes #11473
In #7575 (comment)
@slivne wrote:
Refs #7668
The text was updated successfully, but these errors were encountered: