Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache will accumelate range tombstones for sstables when large row/parition/cell exist - lets not allow this #7750

Open
bhalevy opened this issue Dec 3, 2020 · 5 comments
Assignees
Labels
Milestone

Comments

@bhalevy
Copy link
Member

bhalevy commented Dec 3, 2020

In #7575 (comment)
@slivne wrote:

lets add a patch in master as well - so we will disable the cache for system.large_*

Refs #7668

@slivne
Copy link
Contributor

slivne commented Dec 5, 2020

reference from cdc log e3dd78b

@slivne slivne added this to the 4.3 milestone Dec 5, 2020
@slivne slivne added the bug label Dec 5, 2020
@avikivity
Copy link
Member

In what way is this a bug?

If you report a bug, explain what is wrong with the system.

If you suggest an enhancement, explain how it will make the system better.

@slivne
Copy link
Contributor

slivne commented Jan 19, 2021

@bhalevy ping lets get this fix sent and merged

@slivne slivne modified the milestones: 4.3, 4.5 Jan 19, 2021
@slivne slivne changed the title Disable caching of system.large_* tables Cache will accumelate range tombstones for sstables when large row/parition/cell exist - lets not allow this Feb 28, 2021
@slivne
Copy link
Contributor

slivne commented Feb 28, 2021

Cache will accumelate range tombsones for sstables holding large partition/row/cell - we will be imporiving the range tombstone management (by changing their represtnation) but till we do so - lets make sure that range tombstones for system.large_XXX are not accumulated by disabling caching of those tables.

@slivne
Copy link
Contributor

slivne commented Feb 28, 2021

@bhalevy please queue this in the workplan as well

@slivne slivne modified the milestones: 4.5, 4.6 Mar 29, 2021
avikivity pushed a commit that referenced this issue Jun 24, 2021
The cache of system.large_{partition,rows,cells} accumulates range
tombstones (#7750), and those
range tombstones can be evicted only together with their partition
(#3288).

Making the system.large_* tables uncached should work around the
problem until #3288 is fixed.

Fixes #8874
Refs #7750
Refs #3288

Signed-off-by: Michael Livshin <michael.livshin@scylladb.com>
Message-Id: <20210623171932.8837-1-michael.livshin@scylladb.com>
lauranovich pushed a commit to lauranovich/scylla that referenced this issue Jul 29, 2021
The cache of system.large_{partition,rows,cells} accumulates range
tombstones (scylladb#7750), and those
range tombstones can be evicted only together with their partition
(scylladb#3288).

Making the system.large_* tables uncached should work around the
problem until scylladb#3288 is fixed.

Fixes scylladb#8874
Refs scylladb#7750
Refs scylladb#3288

Signed-off-by: Michael Livshin <michael.livshin@scylladb.com>
Message-Id: <20210623171932.8837-1-michael.livshin@scylladb.com>
@slivne slivne modified the milestones: 4.6, 4.7 Nov 10, 2021
nyh added a commit to nyh/scylla that referenced this issue Sep 6, 2022
I created new issues for each missing field in DescribeTable's
response for GSIs and LSIs, so in this patch we edit the xfail
messages in the test to refer to these issues.

Additionally, we only had a test for these fields for GSIs, so this
patch also adds a similar test for LSIs. I turns out there is a
difference between the two tests -  the two fields IndexStatus and
ProvisionedThroughput are returned for GSIs, but not for LSIs.

Refs scylladb#7750
Refs scylladb#11466
Refs scylladb#11470
Refs scylladb#11471

Signed-off-by: Nadav Har'El <nyh@scylladb.com>
psarna pushed a commit that referenced this issue Sep 7, 2022
I created new issues for each missing field in DescribeTable's
response for GSIs and LSIs, so in this patch we edit the xfail
messages in the test to refer to these issues.

Additionally, we only had a test for these fields for GSIs, so this
patch also adds a similar test for LSIs. I turns out there is a
difference between the two tests -  the two fields IndexStatus and
ProvisionedThroughput are returned for GSIs, but not for LSIs.

Refs #7750
Refs #11466
Refs #11470
Refs #11471

Signed-off-by: Nadav Har'El <nyh@scylladb.com>

Closes #11473
@DoronArazii DoronArazii modified the milestones: 5.0, 5.x Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants