When writing an sstable fails the sstable temporary dir is left behind #9522
Labels
Milestone
Comments
bhalevy
added a commit
to bhalevy/scylla
that referenced
this issue
Mar 2, 2022
If the sstable is marked for deletion, e.g. when writing the sstable fails for any reason before it's sealed, make sure to remove the sstable's temporary directory, if present, besides the sstables files. This condition is benign as these empty temp dirs are removed when scylla starts up, but the do accumulate and we better remove them too. Fixes scylladb#9522 Test: unit(dev) Signed-off-by: Benny Halevy <bhalevy@scylladb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a cosmetic issue in nature.
If we fail to write a sstable for any reason before it's sealed, we do delete its component files, but we leave behind an empty temporary subdirectory.
This directory is benign and should be cleaned up next time scylla starts, but it would be more elegant if we remove in on the error path in https://github.com/scylladb/scylla/blob/5f513ed28b6048338ce0b1a913df567514927684/sstables/sstables.cc#L2443-L2462
The text was updated successfully, but these errors were encountered: