test.py: don't stop cluster's site if not started #11939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI state |
alecco
force-pushed
the
testpy-topology-start-failure
branch
from
61f0935
to
c53a1b5
Compare
|
Changes in c53a1b5:
|
alecco
changed the title
alecco
force-pushed
the
testpy-topology-start-failure
branch
from
c53a1b5
to
697e7a9
Compare
|
Changes in 697e7a9:
|
|
CI state |
Failure due to #8079 (comment). |
|
CI state |
kostja
approved these changes
Nov 11, 2022
alecco
force-pushed
the
testpy-topology-start-failure
branch
from
697e7a9
to
bd7bd97
Compare
|
Changes in bd7bd97:
|
|
CI state |
The site member is created in ScyllaCluster.start(), for startup failure this might not be initialized, so check it's present before stop()ing it. And delete it as it's not running and proper initialization should call ScyllaCluster.start(). Signed-off-by: Alejo Sanchez <alejo.sanchez@scylladb.com>
alecco
force-pushed
the
testpy-topology-start-failure
branch
from
bd7bd97
to
0920771
Compare
Unrelated failure |
|
Changes in 0920771:
|
|
CI state |
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
ScyllaCluster.siteis present before callingstop(). This might happen due to bad starts whenScyllaCluster.stop()is called butScyllaCluster.start()failed.