-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/cql-pytest: add simple tests for COUNT aggregation #12478
Conversation
CI state |
The new test caused Scylla to crash in a weird way:
I rebased on new master hoping maybe the crash was something known and already fixed, but if not, I'll need to debug it. Maybe the "internal error" I saw (#12475) can in some circumstances cause a crash? |
This patch adds a few simple functional test for the COUNT aggregation feature, and in particular how count(*) differs from count(v), and how COUNT interacts with the GROUP BY operation. 3 of the 8 new tests are marked xfail, and reproduce two newly discovered issues: Refs scylladb#12475: Global COUNT with empty IN results in an internal error instead of the expected empty count. Refs scylladb#12477: Combining COUNT with GROUP by results with empty results in Cassandra, and one result with empty count in Scylla. Signed-off-by: Nadav Har'El <nyh@scylladb.com>
CI state |
Hmm, yes :-( It turns out that the test for #12475 ( The failing test is simply running:
This silly query, with an empty "in", causes Scylla to crash in debug mode. The error is |
I'm closing PR and will open a new one which will fix one of the bugs that the test found - that cause Scylla to crash in debug mode (because of an "on_internal_error") and the CI to fail. |
Opened #12715 to replace this one. |
This patch adds a few simple functional test for the COUNT aggregation feature, and in particular how count(*) differs from count(v), and how COUNT interacts with the GROUP BY operation.
3 of the 8 new tests are marked xfail, and reproduce two newly discovered issues:
Refs #12475: Global COUNT with empty IN results in an internal error
instead of the expected empty count.
Refs #12477: Combining COUNT with GROUP by results with empty results
in Cassandra, and one result with empty count in Scylla.
Signed-off-by: Nadav Har'El nyh@scylladb.com