Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/cql-pytest: TestScyllaSsstableSchemaLoading: wait for ongoing compactions #13555

Closed

Conversation

denesb
Copy link
Contributor

@denesb denesb commented Apr 18, 2023

The tests in this class rely on no compaction overlapping with their progress. Despite disabling auto-compaction for the scope of this test class, we still observed the very first test in the suite failing sometimes in debug mode. This is most likely a compaction started before disabling auto-compaction, which (due to the slow debug build) finishes such that it deletes the compacted sstables, right as one of the tests runs.
To prevent this, use the recently introduced tasks api to check and wait for any ongoing compaction before proceeding with the tests.

Fixes: #13553

…mpactions

The tests in this class rely on no compaction overlapping with their
progress. Despite disabling auto-compaction for the scope of this test
class, we still observed the very first test in the suite failing
sometimes in debug mode. This is most likely a compaction started before
disabling auto-compaction, which (due to the slow debug build) finishes
such that it deletes the compacted sstables, right as one of the tests
runs.
To prevent this, use the recently introduced tasks api to check and wait
for any ongoing compaction before proceeding with the tests.

Fixes: scylladb#13553
@denesb denesb requested a review from nyh as a code owner April 18, 2023 06:14
@scylladb-promoter
Copy link
Contributor

@denesb
Copy link
Contributor Author

denesb commented Apr 18, 2023

@scylladb-promoter
Copy link
Contributor

@denesb
Copy link
Contributor Author

denesb commented Apr 18, 2023

CI state FAILURE - https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/690/

Same as above.

@denesb
Copy link
Contributor Author

denesb commented Apr 18, 2023

Closing, the bug is that nodetool.with_autocompaction_disabled() uses the wrong api call to disable the autocompaction, and that one fails (silently).

@denesb denesb closed this Apr 18, 2023
@denesb denesb deleted the test-tools-wait-for-compaction branch April 18, 2023 13:16
@scylladb-promoter
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_tools.TestScyllaSsstableSchemaLoading.test_table_dir_data_dir is flaky
2 participants