migration_notifier: get schema_ptr by value #15098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent use-after-free as seen in scylladb#15097 where a temp schema_ptr retrieved from a global_schema_ptr get destroyed when the notification function yielded. Capturing the schema_ptr on the coroutine frame is inexpensive since its a shared ptr and it makes sure that the schema remains valid throughput the coroutine life time. Fixes scylladb#15097 Signed-off-by: Benny Halevy <bhalevy@scylladb.com>
|
It looks like the caller is losing the temporary arg since it uses a regular |
|
When did the regression start? |
tgrabiec
approved these changes
Aug 20, 2023
Probably 825d617. |
Right. Previously the arg was captured by the async lambda before the function yielded |
|
CI state |
raphaelsc
pushed a commit
to raphaelsc/scylla
that referenced
this pull request
Aug 22, 2023
To prevent use-after-free as seen in scylladb#15097 where a temp schema_ptr retrieved from a global_schema_ptr get destroyed when the notification function yielded. Capturing the schema_ptr on the coroutine frame is inexpensive since its a shared ptr and it makes sure that the schema remains valid throughput the coroutine life time. Fixes scylladb#15097 Signed-off-by: Benny Halevy <bhalevy@scylladb.com> Closes scylladb#15098
raphaelsc
pushed a commit
to raphaelsc/scylla
that referenced
this pull request
Aug 29, 2023
To prevent use-after-free as seen in scylladb#15097 where a temp schema_ptr retrieved from a global_schema_ptr get destroyed when the notification function yielded. Capturing the schema_ptr on the coroutine frame is inexpensive since its a shared ptr and it makes sure that the schema remains valid throughput the coroutine life time. Fixes scylladb#15097 Signed-off-by: Benny Halevy <bhalevy@scylladb.com> Closes scylladb#15098
bhalevy
added a commit
to bhalevy/scylla
that referenced
this pull request
Oct 29, 2023
To prevent use-after-free as seen in scylladb#15097 where a temp schema_ptr retrieved from a global_schema_ptr get destroyed when the notification function yielded. Capturing the schema_ptr on the coroutine frame is inexpensive since its a shared ptr and it makes sure that the schema remains valid throughput the coroutine life time. \Fixes scylladb#15097 Signed-off-by: Benny Halevy <bhalevy@scylladb.com> \Closes scylladb#15098 (cherry picked from commit 0f54e24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent use-after-free as seen in
#15097
where a temp schema_ptr retrieved from a global_schema_ptr get destroyed when the notification function yielded.
Capturing the schema_ptr on the coroutine frame
is inexpensive since its a shared ptr and it makes sure that the schema remains valid throughput the coroutine life time.
Fixes #15097