-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
querier: add more information about the read on semaphore mismatch #15508
querier: add more information about the read on semaphore mismatch #15508
Conversation
CI state |
Also rephase the messages a bit so they are more uniform. The goal of this change is to make semaphore mismatches easier to diagnose, by including the table name and the permit name in the printout. While at it, add a test for semaphore mismatch, it didn't have one. Refs: scylladb#15485
a69ad78
to
571510b
Compare
v2:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
CI state |
#15285, re-kicked. |
CI state |
@scylladb/scylla-maint ping. |
@scylladb/scylla-maint ping. |
Also rephase the messages a bit so they are more uniform. The goal of this change is to make semaphore mismatches easier to diagnose, by including the table name and the permit name in the printout.
While at it, add a test for semaphore mismatch, it didn't have one.
Refs: #15485