Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update seastar submodule #16201

Closed
wants to merge 1 commit into from
Closed

Update seastar submodule #16201

wants to merge 1 commit into from

Conversation

avikivity
Copy link
Member

  • seastar 830ce8673...25e2487da (33):

    epoll: Avoid spinning on aborted connections
    Fixes Scylla cluster nodes utilizes 100% of CPU even with no load #12774
    Fixes nodetool drain issues on 4.1.10  #7753
    Fixes docs: Issue in page Nodetool refresh - MV and SI section phrasing is somewhat messed up or missing some words #13337
    Merge 'Sanitize test-only reactor facilities' from Pavel Emelyanov
    test/unit: fix fmt version check
    reactor/scheduling_group: Handle at_destroy queue special in init_new_scheduling_group_key etc
    build: add spaces before () and after commands
    reactor: use zero-initialization to initialize io_uring_params
    Merge 'build: do not return a non-false condition if the option is off ' from Kefu Chai
    memory: do not use variable length array
    build: use tri_state_option() to link against Sanitizers
    build: do not define SEASTAR_TYPE_ERASE_MORE on all builds
    Revert "shared_future: make available() immediate after set_value()"
    test_runner: do not throw when seastar.app fails to start
    Merge 'Address issue where Seastar faults in toeplitz hash when reassembling fragment' from John Hester
    defer, closeable: do not use [[nodiscard(str)]]
    Merge 'build: generate config-specific rules using generator expressions' from Kefu Chai
    treewide: use *_v and *_t for better readability
    build: use different names for .pc files for each build mode
    perftune.py: skip discovering IRQs for iSCSI disks
    io-tester: explicit use uint64_t for boost::irange(...)
    gate: correct the typo in doxygen comment
    shared_future: make available() immediate after set_value()
    smp: drop unused templates
    include fmt/ostream.h to make headers self-sufficient
    Support ccache in ./configure.py
    rpc_tester: Disable -Wuninitialized when including boost.accumulators
    file: construct directory_entry with aggregated ctor
    file: s/ino64_t/ino_t/, s/off64_t/off_t/
    sstring_test: include fmt/std.h only if fmtlib >= 10.0.0
    file: do not include coroutine headers if coroutine is disabled
    fair_queue::unregister_priority_class:fix assertion
    Merge 'Generalize net::udp_channel into net::datagram_channel' from Michał Sala
    Merge 'Add file::list_directory() that co_yields entries' from Pavel Emelyanov
    http/file_handler: remove unnecessary cast

@github-actions github-actions bot deleted a comment from aws-amplify-us-east-2 bot Nov 28, 2023
@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build
✅ - Unit Tests
❌ - Sanity Tests

Failed Tests (4263/4512):

Build Details:

@avikivity
Copy link
Member Author

Only 4263 failures.

@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build
✅ - Unit Tests
❌ - Sanity Tests

Failed Tests (4263/4512):

Build Details:

@avikivity
Update seastar submodule
e9c7527 
* seastar 830ce8673...55a821524 (34):
  > Revert "reactor/scheduling_group: Handle at_destroy queue special in init_new_scheduling_group_key etc"
  > epoll: Avoid spinning on aborted connections
Fixes scylladb#12774
Fixes scylladb#7753
Fixes scylladb#13337
  > Merge 'Sanitize test-only reactor facilities' from Pavel Emelyanov
  > test/unit: fix fmt version check
  > reactor/scheduling_group: Handle at_destroy queue special in init_new_scheduling_group_key etc
  > build: add spaces before () and after commands
  > reactor: use zero-initialization to initialize io_uring_params
  > Merge 'build: do not return a non-false condition if the option is off ' from Kefu Chai
  > memory: do not use variable length array
  > build: use tri_state_option() to link against Sanitizers
  > build: do not define SEASTAR_TYPE_ERASE_MORE on all builds
  > Revert "shared_future: make available() immediate after set_value()"
  > test_runner: do not throw when seastar.app fails to start
  > Merge 'Address issue where Seastar faults in toeplitz hash when reassembling fragment' from John Hester
  > defer, closeable: do not use [[nodiscard(str)]]
  > Merge 'build: generate config-specific rules using generator expressions' from Kefu Chai
  > treewide: use *_v and *_t for better readability
  > build: use different names for .pc files for each build mode
  > perftune.py: skip discovering IRQs for iSCSI disks
  > io-tester: explicit use uint64_t for boost::irange(...)
  > gate: correct the typo in doxygen comment
  > shared_future: make available() immediate after set_value()
  > smp: drop unused templates
  > include fmt/ostream.h to make headers self-sufficient
  > Support ccache in ./configure.py
  > rpc_tester: Disable -Wuninitialized when including boost.accumulators
  > file: construct directory_entry with aggregated ctor
  > file: s/ino64_t/ino_t/, s/off64_t/off_t/
  > sstring_test: include fmt/std.h only if fmtlib >= 10.0.0
  > file: do not include coroutine headers if coroutine is disabled
  > fair_queue::unregister_priority_class:fix assertion
  > Merge 'Generalize `net::udp_channel` into `net::datagram_channel`' from Michał Sala
  > Merge 'Add file::list_directory() that co_yields entries' from Pavel Emelyanov
  > http/file_handler: remove unnecessary cast
@scylladb-promoter
Copy link
Contributor

🟢 CI State: SUCCESS

✅ - Build
✅ - Sanity Tests
✅ - Unit Tests

Build Details:

@tchaikov
Copy link
Contributor

created #16217 which includes the workaround of scylladb/seastar#1913 .

@avikivity
Copy link
Member Author

created #16217 which includes the workaround of scylladb/seastar#1913 .

Do you mean this one is broken?

@tchaikov
Copy link
Contributor

no, this one is good. i thought you wanted to include a seastar in better shape which suffers less from scylladb/seastar#1913. if you don't care, neither do i.

@avikivity
Copy link
Member Author

Ah, we don't use experiemental_list_directory so aren't vulnerable to the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@avikivity @scylladb-promoter @tchaikov