[Backport 5.4] row cache: do_update: abort on execute error #16256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y Halevy Currently the cache updaters aren't exception safe yet they are intended to be. Instead of allowing exceptions from `external_updater::execute` escape `row_cache::update`, abort using `on_fatal_internal_error`. Future changes should harden all `execute` implementations to effectively make them `noexcept`, then the pure virtual definition can be made `noexcept` to cement that. \Fixes scylladb#15576 \Closes scylladb#15577 * github.com:scylladb/scylladb: row_cache: abort on exteral_updater::execute errors row_cache: do_update: simplify _prev_snapshot_pos setup (cherry picked from commit 4a0f164)
|
CI state |
|
Is this fixing a regression? |
No, it was like that for ages. |
bhalevy
changed the title
|
Agree |
avikivity
pushed a commit
that referenced
this pull request
Dec 3, 2023
…y Halevy Currently the cache updaters aren't exception safe yet they are intended to be. Instead of allowing exceptions from `external_updater::execute` escape `row_cache::update`, abort using `on_fatal_internal_error`. Future changes should harden all `execute` implementations to effectively make them `noexcept`, then the pure virtual definition can be made `noexcept` to cement that. \Fixes #15576 \Closes #15577 * github.com:scylladb/scylladb: row_cache: abort on exteral_updater::execute errors row_cache: do_update: simplify _prev_snapshot_pos setup (cherry picked from commit 4a0f164) Closes #16256
|
Looks like next-5.4 was not triggered, by this merge. |
@denesb looking into it |
|
@denesb Fixed. probably caused by the Jenkins issues we faced yesterday. going over all releases to make sure they are working |
|
@denesb please merge |
denesb
added a commit
that referenced
this pull request
Dec 7, 2023
…y Halevy Currently the cache updaters aren't exception safe yet they are intended to be. Instead of allowing exceptions from `external_updater::execute` escape `row_cache::update`, abort using `on_fatal_internal_error`. Future changes should harden all `execute` implementations to effectively make them `noexcept`, then the pure virtual definition can be made `noexcept` to cement that. \Fixes #15576 \Closes #15577 * github.com:scylladb/scylladb: row_cache: abort on exteral_updater::execute errors row_cache: do_update: simplify _prev_snapshot_pos setup (cherry picked from commit 4a0f164) Closes #16256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the cache updaters aren't exception safe
yet they are intended to be.
Instead of allowing exceptions from
external_updater::executeescaperow_cache::update,abort using
on_fatal_internal_error.Future changes should harden all
executeimplementationsto effectively make them
noexcept, then the pure virtualdefinition can be made
noexceptto cement that.\Fixes #15576
\Closes #15577
row_cache: abort on exteral_updater::execute errors
row_cache: do_update: simplify _prev_snapshot_pos setup
(cherry picked from commit 4a0f164)