Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fixes for nodetool commands with Alternator GSI in the database #16294

Closed
wants to merge 1 commit into from

Conversation

nyh
Copy link
Contributor

@nyh nyh commented Dec 5, 2023

No description provided.

@nyh
Copy link
Contributor Author

nyh commented Dec 5, 2023

Oops, wrong base, I'll rebase

Fixes scylladb#16153

* jmx 166599f...f45067f (3):
  > ColumnFamilyStore: only quote table names if necessary
  > APIBuilder: allow quoted scope names
  > ColumnFamilyStore: don't fail if there is a table with ":" in its name

* java dfbf3726ee...3764ae94db (1):
  > NodeProbe: allow addressing table name with colon in it

Signed-off-by: Nadav Har'El <nyh@scylladb.com>
@scylladb-promoter
Copy link
Contributor

🟢 CI State: SUCCESS

✅ - Build
✅ - Unit Tests
✅ - Sanity Tests

Build Details:

  • Duration: 2 hr 23 min
  • Builder: spider3.cloudius-systems.com

nyh added a commit that referenced this pull request Dec 6, 2023
Fixes #16153

* jmx 166599f...f45067f (3):
  > ColumnFamilyStore: only quote table names if necessary
  > APIBuilder: allow quoted scope names
  > ColumnFamilyStore: don't fail if there is a table with ":" in its name

* java dfbf3726ee...3764ae94db (1):
  > NodeProbe: allow addressing table name with colon in it

Signed-off-by: Nadav Har'El <nyh@scylladb.com>

Closes #16294
@mykaul
Copy link
Contributor

mykaul commented Dec 13, 2023

@nyh - please resolve conflicts.

@nyh
Copy link
Contributor Author

nyh commented Dec 17, 2023

@nyh - please resolve conflicts.

I think these aren't conflicts - my PR actually went in, and the PR was just not automatically closed (it doesn't get closed when it's not the main branch). Closing manually.

@nyh nyh closed this Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants