Backport fixes for nodetool commands with Alternator GSI in the database #16296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scylladb#16153 * java e716e1bd1d...80701efa8d (1): > NodeProbe: allow addressing table name with colon in it /home/nyh/scylla/tools$ git submodule summary jmx | cat * jmx bc4f8ea...f21550e (3): > ColumnFamilyStore: only quote table names if necessary > APIBuilder: allow quoted scope names > ColumnFamilyStore: don't fail if there is a table with ":" in its name Signed-off-by: Nadav Har'El <nyh@scylladb.com>
|
CI state |
nyh
added a commit
that referenced
this pull request
Dec 6, 2023
Fixes #16153 * java e716e1bd1d...80701efa8d (1): > NodeProbe: allow addressing table name with colon in it /home/nyh/scylla/tools$ git submodule summary jmx | cat * jmx bc4f8ea...f21550e (3): > ColumnFamilyStore: only quote table names if necessary > APIBuilder: allow quoted scope names > ColumnFamilyStore: don't fail if there is a table with ":" in its name Signed-off-by: Nadav Har'El <nyh@scylladb.com> Closes #16296
|
@nyh - can this be merged? |
It was already merged. The PR was just not automatically closed (it doesn't get closed when it's not the main branch). Closing manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16153
/home/nyh/scylla/tools$ git submodule summary jmx | cat