replica/database: stop compaction before closing system tables during shutdown #17218
Conversation
|
The So, the only possible race condition is the one that happens when all the system tables are closed in parallel - there is a chance that compaction_history table closes early when other system tables are still compacting. So, to prevent that this patch just stops all the compaction of the system tables before starting to closing them in parallel. This is now protected by a barrier as well to prevent another shard from updating |
lkshminarayanan
force-pushed
the
fix_test_can_limit_compaction_throughput
branch
from
445ed1c
to
d2bd963
Compare
🔴 CI State: FAILURE✅ - Build Failed Tests (2/24453):Build Details:
|
🟢 CI State: SUCCESS✅ - Build Build Details:
|
lkshminarayanan
force-pushed
the
fix_test_can_limit_compaction_throughput
branch
from
d2bd963
to
b76aa4e
Compare
lkshminarayanan
force-pushed
the
fix_test_can_limit_compaction_throughput
branch
from
b76aa4e
to
eaa9d0b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
🔴 CI State: FAILURE✅ - Build Failed Tests (2/24588):Build Details:
|
🟢 CI State: SUCCESS✅ - Build Build Details:
|
…ing shutdown During shutdown, as all system tables are closed in parallel, there is a possibility of a race condition between compaction stoppage and the closure of the compaction_history table. So, quiesce all the compaction tasks before attempting to close the tables. Fixes scylladb#15721 Signed-off-by: Lakshmi Narayanan Sreethar <lakshmi.sreethar@scylladb.com>
lkshminarayanan
force-pushed
the
fix_test_can_limit_compaction_throughput
branch
from
eaa9d0b
to
2903d26
Compare
🟢 CI State: SUCCESS✅ - Build Build Details:
|
…ing shutdown During shutdown, as all system tables are closed in parallel, there is a possibility of a race condition between compaction stoppage and the closure of the compaction_history table. So, quiesce all the compaction tasks before attempting to close the tables. Fixes #15721 Signed-off-by: Lakshmi Narayanan Sreethar <lakshmi.sreethar@scylladb.com> Closes #17218 (cherry picked from commit 3b7b315)
…ing shutdown During shutdown, as all system tables are closed in parallel, there is a possibility of a race condition between compaction stoppage and the closure of the compaction_history table. So, quiesce all the compaction tasks before attempting to close the tables. Fixes scylladb#15721 Signed-off-by: Lakshmi Narayanan Sreethar <lakshmi.sreethar@scylladb.com> Closes scylladb#17218
During shutdown, as all system tables are closed in parallel, there is a possibility of a race condition between compaction stoppage and the closure of the compaction_history table. So, stop all the compaction tasks before attempting to close the tables.
Fixes #15721