Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair: Add ranges_parallelism option support for tablet #18385

Closed

Conversation

asias
Copy link
Contributor

@asias asias commented Apr 24, 2024

The ranges_parallelism option is introduced in commit 9b3fd94. Currently, this option works for vnode table repair only.

This patch enables it for tablet repair, since it is useful for tablet repair too.

Fixes #18383

@asias asias requested a review from tgrabiec as a code owner April 24, 2024 01:57
@asias asias self-assigned this Apr 24, 2024
@scylladb-promoter
Copy link
Contributor

🔴 CI State: FAILURE

✅ - Build
✅ - Container Test
✅ - dtest with topology changes
❌ - dtest
✅ - Unit Tests

Failed Tests (1/30308):

Build Details:

  • Duration: 2 hr 28 min
  • Builder: spider2.cloudius-systems.com

@scylladb-promoter
Copy link
Contributor

🟢 CI State: SUCCESS

✅ - Build
✅ - Unit Tests Custom
The following new/updated tests ran 100 times for each mode:
🔹 topology_custom/test_replace
✅ - Container Test
✅ - dtest
✅ - dtest with topology changes
✅ - Unit Tests

Build Details:

  • Duration: 3 hr 28 min
  • Builder: spider3.cloudius-systems.com

@denesb
Copy link
Contributor

denesb commented Apr 25, 2024

@denesb
Copy link
Contributor

denesb commented Apr 25, 2024

@asias please rebase, there are conflicts.

@asias
Copy link
Contributor Author

asias commented Apr 26, 2024

@asias please rebase, there are conflicts.

done

@asias asias force-pushed the ranges_parallelism_tablet_support branch from f497ad3 to e9e1951 Compare April 26, 2024 05:42
@scylladb-promoter
Copy link
Contributor

🟢 CI State: SUCCESS

✅ - Build
✅ - Container Test
✅ - dtest
✅ - dtest with topology changes
✅ - Unit Tests

Build Details:

  • Duration: 2 hr 44 min
  • Builder: spider4.cloudius-systems.com

@denesb
Copy link
Contributor

denesb commented Apr 26, 2024

There are conflicts with next :(
Will need another rebase after promotion.

The ranges_parallelism option is introduced in commit 9b3fd94.
Currently, this option works for vnode table repair only.

This patch enables it for tablet repair, since it is useful for
tablet repair too.

Fixes scylladb#18383
@asias asias force-pushed the ranges_parallelism_tablet_support branch from e9e1951 to 88643d0 Compare May 6, 2024 02:34
@asias
Copy link
Contributor Author

asias commented May 6, 2024

There are conflicts with next :( Will need another rebase after promotion.

Rebased. Let's try again.

@scylladb-promoter
Copy link
Contributor

🟢 CI State: SUCCESS

✅ - Build
✅ - Container Test
✅ - dtest with topology changes
✅ - dtest
✅ - Unit Tests

Build Details:

  • Duration: 2 hr 27 min
  • Builder: spider5.cloudius-systems.com

@asias
Copy link
Contributor Author

asias commented May 7, 2024

@denesb Ping for merge.

denesb pushed a commit that referenced this pull request May 8, 2024
The ranges_parallelism option is introduced in commit 9b3fd94.
Currently, this option works for vnode table repair only.

This patch enables it for tablet repair, since it is useful for
tablet repair too.

Fixes #18383

Closes #18385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repair: ranges_parallelism option is not supported for tablet
3 participants