partition_snapshot_reader: do not accidentally copy schema #9507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions `upper_bound` and `lower_bound` had signatures: ``` template<typename T, typename... Args> static rows_iter_type lower_bound(const T& t, Args... args); ``` This caused a dacay from `const schema&` to `schema` as one of the args, which in turn copied the schema in a fair number of the queries. Fix that by setting the parameter type to `Args&&`, which doesn't discard the reference. Fixes scylladb#9502
benipeled
pushed a commit
to benipeled/scylla
that referenced
this pull request
May 31, 2022
Functions `upper_bound` and `lower_bound` had signatures: ``` template<typename T, typename... Args> static rows_iter_type lower_bound(const T& t, Args... args); ``` This caused a dacay from `const schema&` to `schema` as one of the args, which in turn copied the schema in a fair number of the queries. Fix that by setting the parameter type to `Args&&`, which doesn't discard the reference. Fixes scylladb#9502 Closes scylladb#9507 (cherry picked from commit 9caf85f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions
upper_boundandlower_boundhad signatures:This caused a dacay from
const schema&toschemaas one of the args,which in turn copied the schema in a fair number of the queries. Fix
that by setting the parameter type to
Args&&, which doesn't discardthe reference.
Fixes #9502