Skip to content

Commit

Permalink
sstring: include <fmt/format.h> instead of <fmt/ostream.h>
Browse files Browse the repository at this point in the history
<fmt/ostream.h> was include in 2975b61 so we can use ostream_formatter,
but later in bef98ab, we stopped using ostream_formatter. so this
header is not necessary anymore.

in this change, we trade this include with a smaller dependency.

also, `include <fmt/ostream.h>` in `fair_queue.hh`, where ostream_formatter
is used, but in that header file, we fail to include `<fmt/ostream.hh`.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes #2176
  • Loading branch information
tchaikov authored and nyh committed Apr 3, 2024
1 parent 1cf4707 commit 47e2ff6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions include/seastar/core/fair_queue.hh
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include <functional>
#include <optional>
#include <queue>
#include <fmt/ostream.h>

namespace bi = boost::intrusive;

Expand Down
2 changes: 1 addition & 1 deletion include/seastar/core/sstring.hh
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
#include <ostream>
#include <functional>
#include <type_traits>
#include <fmt/ostream.h>
#include <fmt/format.h>
#endif
#include <seastar/util/std-compat.hh>
#include <seastar/util/modules.hh>
Expand Down

0 comments on commit 47e2ff6

Please sign in to comment.