fsqual: stop causing memory leak error on LeakSanitizer #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Nov 8, 2022
src/core/fsqual.cc
Outdated
| @@ -98,6 +98,7 @@ bool filesystem_has_good_aio_support(sstring directory, bool verbose) { | |||
| std::cout << "context switch per appending io: " << rate | |||
| << " (" << verdict << ")\n"; | |||
| } | |||
| free(buf); | |||
There was a problem hiding this comment.
nit, might want to use
auto del = defer([&] () noexcept { ::free(buf); });right after the aligned_alloc() call for better readability?
There was a problem hiding this comment.
I concur on this nit. After allocation there are some exception throws, so the buffer would still leak. @syuu1228 , please
There was a problem hiding this comment.
nit, might want to use
auto del = defer([&] () noexcept { ::free(buf); });right after the
aligned_alloc()call for better readability?
Replaced free(buf) with auto del = defer([&] () noexcept { ::free(buf); }).
When we enable the sanitizer, we get following error while running
iotune:
==86505==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 4096 byte(s) in 1 object(s) allocated from:
#0 0x5701b8 in aligned_alloc (/home/syuu/seastar.2/build/sanitize/apps/iotune/iotune+0x5701b8) (BuildId: 411f9852d64ed8982d5b33d02489b5932d92b8b7)
scylladb#1 0x6d0813 in seastar::filesystem_has_good_aio_support(seastar::basic_sstring<char, unsigned int, 15u, true>, bool) /home/syuu/seastar.2/src/core/fsqual.cc:74:16
scylladb#2 0x5bcd0d in main::$_0::operator()() const::'lambda'()::operator()() const /home/syuu/seastar.2/apps/iotune/iotune.cc:742:21
scylladb#3 0x5bb1f1 in seastar::future<int> seastar::futurize<int>::apply<main::$_0::operator()() const::'lambda'()>(main::$_0::operator()() const::'lambda'()&&, std::tuple<>&&) /home/syuu/seastar.2/include/seastar/core/future.hh:2118:28
scylladb#4 0x5bb039 in seastar::futurize<std::invoke_result<main::$_0::operator()() const::'lambda'()>::type>::type seastar::async<main::$_0::operator()() const::'lambda'()>(seastar::thread_attributes, main::$_0::operator()() const::'lambda'()&&)::'lambda'()::operator()() const /home/syuu/seastar.2/include/seastar/core/thread.hh:258:13
scylladb#5 0x5bb039 in seastar::noncopyable_function<void ()>::direct_vtable_for<seastar::futurize<std::invoke_result<main::$_0::operator()() const::'lambda'()>::type>::type seastar::async<main::$_0::operator()() const::'lambda'()>(seastar::thread_attributes, main::$_0::operator()() const::'lambda'()&&)::'lambda'()>::call(seastar::noncopyable_function<void ()> const*) /home/syuu/seastar.2/include/seastar/util/noncopyable_function.hh:124:20
scylladb#6 0x8e0a77 in seastar::thread_context::main() /home/syuu/seastar.2/src/core/thread.cc:299:9
scylladb#7 0x7f30ff8547bf (/lib64/libc.so.6+0x547bf) (BuildId: 85c438f4ff93e21675ff174371c9c583dca00b2c)
SUMMARY: AddressSanitizer: 4096 byte(s) leaked in 1 allocation(s).
This is because we don't free buffer which allocated at filesystem_has_good_aio_support(), we should free it to avoid such error.
And this is needed to test Scylla machine image with debug mode binary,
since it tries to run iotune with the sanitizer and fails.
syuu1228
force-pushed
the
fsqual_free_buffer
branch
from
24ad1c0
to
e827de0
Compare
yaronkaikov
requested review from
tchaikov and
xemul
and removed request for
tchaikov
|
@avikivity We need this on Scylla since we are getting this error while building debug mode AMI (when scylla_kernel_check running), could you update the submodule? |
|
@avikivity @nyh Can you please update the submodule? |
|
Looks like submodule update merged on master: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we enable the sanitizer, we get following error while running iotune:
This is because we don't free buffer which allocated at filesystem_has_good_aio_support(), we should free it to avoid such error.
And this is needed to test Scylla machine image with debug mode binary, since it tries to run iotune with the sanitizer and fails.