Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus: revert the condition for enabling aggregation #2232

Closed
wants to merge 1 commit into from

Commits on May 9, 2024

  1. prometheus: revert the condition for enabling aggregation

    in d7e16bb, we added the query time configuration for disabling
    aggregation, but the condition for disabling aggregation was wrong.
    before that change, we always enable the aggregation, but after that
    change, the aggregation is disabled when the value of query parameter
    of "__aggregate__" is not "false". in other words,
    
    - if this query parameter is not set, the aggregation is disabled. this
      changes the existing behavior.
    - if this query parameter's value is "false", the aggregation is
      enabeld. this is not the expected behavior.
    
    so, in this change
    
    - change the parameter from `disable_aggregation` to
      `enable_aggregation`. as the positive condition is
      always easier to understand.
    - and update the handling accodingly.
    
    Fixes d7e16bb
    Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
    tchaikov committed May 9, 2024
    Configuration menu
    Copy the full SHA
    a8b31ec View commit details
    Browse the repository at this point in the history