Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std-compat: remove #include:s which were added for pre C++17 #2257

Closed
wants to merge 1 commit into from

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented May 21, 2024

these #includes were introduced by 0bbcbba and 79e846e, for backward compatibility with pre-C++17 era. since we've dropped C++17 support, and now only support C++20 and up. let's remove these cruft.

@tchaikov tchaikov force-pushed the std-compat-drop-includes branch 2 times, most recently from 0ba57ad to a1044a6 Compare May 21, 2024 14:53
@tchaikov tchaikov force-pushed the std-compat-drop-includes branch 6 times, most recently from 03fc296 to 6f6fe5c Compare May 21, 2024 16:05
these `#include`s were introduced by 0bbcbba and 79e846e, for backward
compatibility with pre-C++17 era. since we've dropped C++17 support,
and now only support C++20 and up. let's remove these cruft.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
@tchaikov
Copy link
Contributor Author

v2:

  • include the headers directly previously included by std-compat.hh

@xemul xemul closed this in b822c94 May 23, 2024
@tchaikov tchaikov deleted the std-compat-drop-includes branch May 23, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants