metrics: Use this_shard_id unconditionally #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a57b17c changed the way `local_engine` gets set. It's now only being set after the reactor has been fully constructed. This breaks a bunch of metrics that are being registered from the reactor constructor (main scheduling group metrics, stall detector, possibly more) as the metrics subsystem uses `engine_is_ready` which internally checks whether `local_engine` is set. With this not being the case it would set the shard id to 0 for all shards. Remove the extra check to `engine_is_ready` as the shard id is initialized before the reactor is being constructed so this is safe to use directly.
|
@tchaikov did you have a chance to look at this? |
not yet, but will do early tomorrow. |
|
@vladzcloudius hi Vlad, this change practically reverts your change of ff098c8. do you mind taking a look ? |
avikivity
approved these changes
Jul 17, 2024
vladzcloudius
approved these changes
Jul 17, 2024
|
Thanks folks, could someone hit the merge button? |
|
@scylladb/seastar-maint hello maintainers, could you help merge this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a57b17c changed the way
local_enginegets set. It's now only being set after the reactor has been fully
constructed.
This breaks a bunch of metrics that are being registered from the
reactor constructor (main scheduling group metrics, stall detector,
possibly more) as the metrics subsystem uses
engine_is_readywhichinternally checks whether
local_engineis set. With this not being thecase it would set the shard id to 0 for all shards.
Remove the extra check to
engine_is_readyas the shard id isinitialized before the reactor is being constructed so this is safe to
use directly.