Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix canonical tag #406

Merged
merged 1 commit into from Mar 19, 2022
Merged

Conversation

dgarcia360
Copy link
Collaborator

Closes #405

Adds dynamically the correct canonical URL:

  • If multiversion is set, the canonical URL has the form: <link rel="canonical" href="{{ html_baseurl }}/{{latest_slug}}/{{ pagename }}.html"/>

  • Otherwise: <link rel="canonical" href="{{ html_baseurl }}/{{ pagename }}.html"/>

@dgarcia360 dgarcia360 changed the title Fix canonical url Fix canonical tag Mar 17, 2022
@netlify
Copy link

netlify bot commented Mar 17, 2022

✔️ Deploy Preview for sphinx-theme canceled.

🔨 Explore the source changes: b7e1c30

🔍 Inspect the deploy log: https://app.netlify.com/sites/sphinx-theme/deploys/62338707b706080008233ce9

Copy link
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can check it with the preview, but the changes look good to me.

@tzach
Copy link
Collaborator

tzach commented Mar 18, 2022

@dgarcia360 not sure I understand the change
Can you please give a few examples, for latest and not latest versions?

@dgarcia360
Copy link
Collaborator Author

Copy link
Collaborator

@tzach tzach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgarcia360 dgarcia360 merged commit a0d1e66 into scylladb:master Mar 19, 2022
@dgarcia360 dgarcia360 deleted the fix-canonical-tag branch March 19, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set correct rel="canonical" URL
3 participants