Skip to content

Commit

Permalink
Improved arg handling rudel-find-{user, document} in rudel.el
Browse files Browse the repository at this point in the history
* rudel.el (rudel-session::rudel-find-user):
  (rudel-session::rudel-find-document): handle optional arguments more
  efficiently
  (rudel-user): added a comment
  • Loading branch information
scymtym committed May 23, 2010
1 parent c83213a commit cc19b12
Show file tree
Hide file tree
Showing 2 changed files with 55 additions and 12 deletions.
48 changes: 48 additions & 0 deletions ChangeLog
@@ -1,5 +1,53 @@
2010-05-23 Jan Moringen <scymtym@users.sourceforge.net>

Improved arg handling rudel-find-{user, document} in rudel.el
* rudel.el (rudel-session::rudel-find-user):
(rudel-session::rudel-find-document): handle optional arguments
more efficiently
(rudel-user): added a comment

Wait for idle state in rudel-infinote-backend::rudel-connect
* infinote/rudel-infinote.el
(rudel-infinote-backend::rudel-connect): wait for the infinote
connection object to enter its idle state

Improved documentation string of class rudel-infinote-node
* infinote/rudel-infinote-node.el (rudel-infinote-node): improved
documentation string

Disabled query on exit for TLS and socket transport processes
* tls/rudel-tls.el (rudel-tls-make-process): set query on exit
flag of the process to nil
* socket/rudel-socket.el
(rudel-tcp-backend::rudel-make-connection):
(rudel-tcp-backend::rudel-wait-for-connections): set :noquery flag
of the new process

Improved docstring of global-rudel-minor-mode in rudel-mode.el
* rudel-mode.el (header): updated copyright
(rudel-header-subscriptions--add-user): renamed lexical-let
binding for clarity
(global-rudel-minor-mode): Added key bindings to documentation
string

Small fixes and improvements in README
* README (INTRODUCTION): fixed a typo
(GETTING STARTED): added comment about enabling
global-rudel-minor-mode in .emacs; added markup to example

Added branches as tags and other updates in TODO
* TODO (Future): added tasks typing notification, document
history, session log, activity indicator, tracking of chunk
modifications, peer view indication; added branch tags
(Milestone 0.4): added branch tags

2010-05-21 Jan Moringen <scymtym@users.sourceforge.net>

Fixed header sections in rudel-operators.el
* rudel-operators.el (header): updated copyright; minor
improvements in commentary section; minor improvements in history
section

Fixed XMPP TLS state name in xmpp/rudel-xmpp-tls.el
* xmpp/rudel-xmpp-tls.el (rudel-xmpp-tls-states): fixed class name
for start-tls state rudel-xmpp-start-tls-start ->
Expand Down
19 changes: 7 additions & 12 deletions rudel.el
Expand Up @@ -201,13 +201,10 @@ with arguments THIS and USER."
which &optional test key)
"Find user WHICH in the user list.
WHICH is compared to the result of KEY using TEST."
(unless test
(setq test #'string=))
(unless key
(setq key #'object-name-string))
(with-slots (users) this
(find which users :key key :test test))
)
(find which users
:key (or key #'object-name-string)
:test (or test #'string=))))

(defmethod rudel-add-document ((this rudel-session) document)
""
Expand Down Expand Up @@ -235,13 +232,10 @@ WHICH is compared to the result of KEY using TEST."
which &optional test key)
"Find document WHICH in the document list.
WHICH is compared to the result of KEY using TEST."
(unless test
(setq test #'string=))
(unless key
(setq key #'object-name-string))
(with-slots (documents) this
(find which documents :key key :test test))
)
(find which documents
:key (or key #'object-name-string)
:test (or test #'string=))))

(defmethod rudel-unsubscribed-documents ((this rudel-session))
""
Expand Down Expand Up @@ -352,6 +346,7 @@ client protocols have to obey."
"Color used to indicate ownership or authorship
by the user. Examples includes text written by the user or the
user name itself.")
;; Hooks
(change-hook :initarg :change-hook
:type list
:initform nil
Expand Down

0 comments on commit cc19b12

Please sign in to comment.