LanguageServer can connect and provide basic functionality to NeoVim client #9
Comments
|
For information, Neovim 0.9 (or perhaps even earlier version) provides a method to connect to LSP rpc via So something in these lines is already possible local function start_lsp()
vim.loop.spawn('/path/to/sclang', {args = {'-i', 'vscode'},}, function ()
-- Some shutdown mechanism here
end)
end
vim.lsp.start({
name="supercollider",
cmd=function(...)
start_lsp()
return vim.lsp.rpc.connect(host, port)
end
}) |
|
Is the ideal here to write a program that results in a binary executable (or is python/node/lua fine)? There is a note in David's original proof of concept that suggests it would be good to not have a dependency on Node. There are many LSPs which are installed via npm etc. so maybe node or whatever is fine. I'd be happy to give this one a go if there is nobody working on it yet. |
|
I've had some time and have been working on a Python script to handle this. I've got most of the functionality in place but I've been testing outside of SC mostly. When I try to run SC from my python script I get this (permission?) error. The command I run on Mac is I had to point it to my config file so it would pick up the Quarks. Below is the error I get but strangely if I just run from the shell it works fine and I see the I'm using Does anyone know what might be going on? Thanks! |
|
SynthDef initClass does: If
|
|
Thanks for info, I was able to track down the issue by looking at that Thanks! |
|
I've almost got this working - I think i need to work on my neovim lsp setup because currently when I open a SC file in neovim it will launch my lsp runner but it won't show a connected LSP. It is definitely launching though and producing promising logs strangely when i exit the neovim buffer I get this (which almost looks like an init call) |
|
@dannyZyg did you get any further with this - I should have some time to help soon. I would love to get it all working in neovim. |
Hey @themissingcow - I haven't looked at this since last year, but I'd love to get it going if possible. I'll try and have a look in the next few days and let you know how I go. I can't quite remember where I got to with it. |
🙏 Ace, thanks. I grabbed that branch on your fork - but had issues manually calling |
@scztt please forgive the naive q - has there been any chat upstream about adding tcp support to sclang? |
|
That's great @themissingcow ! Really glad to hear you carried on with it and fixed it. Curious to see what changes were needed. Excited to use this too! |
WIP: https://github.com/themissingcow/LanguageServer.quark/commits/nvim-fixes Still having some issues where the last packet of multi-packet messages is getting lost. Should hopefully have some time next week to look into it again, and will post the updated Python wrapper. |
|
@dannyZyg got bit further here https://github.com/themissingcow/LanguageServer.quark/commits/lsp-runner. Were you planning on working on the wrapper script some more? Otherwise I was thinking about adding support for configuring paths/config and the likes via LSP initialization options, so you can set these up in your neovim registration (and potentially per-project). Didn't want to mess with your plans though! |
|
Hey @themissingcow, thanks for continuing with this! I was planning on coming back to it at some point but had not got around to it, so I'm really pleased you picked it up. Your config suggestions sound good, I'd be happy for you to add that. It would be great to get all of this merged in though, so we can make small improvements as we go and have something workable soon! Let me know how you'd like to proceed with that? What state is it in now? I'll try and test out your changes tonight! |
|
Hey @dannyZyg
Yeah def. I guess I was hoping to get the setting from the LSP initialise working as a starting point, but I guess it's kind of working as is.
I was just testing and cross-referenced the LSP docs and I realised that some of the changes I made in |
@themissingcow That's no problem, feel free to add that in! I don't mean to rush you, I'm just excited to use this haha 😄 |
@dannyZyg I updated the branch, I have it kind of working (though I think there are still some gremlins with large messages). I'm adding this to my local configs = require('lspconfig.configs')
configs.supercollider = {
default_config = {
cmd = {"python", "/path/to/lsp_runner/main.py", "--sc-lang-path", '/Applications/SuperCollider.app/Contents/MacOS/sclang', "--sc-config-path", "/path/to/sclang_conf.yaml"},
filetypes = {'supercollider'},
root_dir = function(fname)
return "/"
end,
settings = {},
},
}And setting this up with vim.filetype.add({
extension = {
sc = "supercollider",
scd = "supercollider",
},
})Which gives me this loveliness: 
|
Provides a python script to support lsp clients which can't use UDP but can use stdio (e.g. neovim) - as described in this issue scztt#9 The script launches sclang in the background and while communicating with the language server quark over UDP, relays this IO over stdio to the client. Special thanks to Tom Cowland for getting this working properly! Co-authored-by: Tom Cowland <info@tomcowland.com>
Based on some preliminary investigation, NeoVim can only connect to LSP servers via a stdin/stdout based communication mechanism. This currently will not work with sclang, as there are many places where sclang forcibly writes to stdout, which would disrupt LSP communication. Instead, for the vscode plugin, we use simple UDP pipes since they are already well-supported by sclang and easy to implement in VSCode. Until the sclang stdout issues can be solved, the UDP mechanism will be used.
IF it is indeed not possible to convince NeoVim to connect to an LSP server via UDP, then the solution to this would be as follows. (Note that this is not throwaway work, as an architecture where the LSP "wrapper" and an sclang instance are separated is probably desirable in the long run anyway.)
There is a preliminary implementation that may be a good starting point here:
https://github.com/davidgranstrom/sclang-lsp-stdio
***LSP READY***is posted (https://github.com/scztt/vscode-supercollider/blob/develop/src/context.ts#LL132C45-L132C61). UDP sockets should be connected directly to stdin/stdout of the utility script so they can communicate with the LSP client (e.g. NeoVim).Note that there MAY be extra work in NeoVim specifically to enable SuperCollider support. There are forum messages outlining some of this work, and some things may already be implemented. See:
The text was updated successfully, but these errors were encountered: