Make fairing asynchronous #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Updates the requirements on [prometheus](https://github.com/tikv/rust-prometheus) to permit the latest version. - [Release notes](https://github.com/tikv/rust-prometheus/releases) - [Changelog](https://github.com/tikv/rust-prometheus/blob/master/CHANGELOG.md) - [Commits](tikv/rust-prometheus@v0.11.0...v0.12.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
RawStr no longer implements FromParam since commit 63a14525d86595a8033715e3bdcd2bf2581eecb1 of Rocket; &str should be used in its place.
The vast majority of requests will have a 'valid' status code and so we can use the http crate's `StatusCode` struct to represent them, which provides a non-allocating `as_str()` method to get the status code label used for built-in metrics. In other cases, fall back to converting the status code to a string, with an allocation.
This uses the new `RouteUri` struct of Rocket.
|
Could you rebase this and update it for current Rocket master? I'd like to give it a test drive. :) |
|
@svenstaro This should already support the latest Rocket master as of 64f3ff7 - I made the changes a couple of days ago! Are you having issues getting it to compile? |
|
Oh, nevermind then. I just thought it was weird that you conflict with your target branch currently. I'll just use your branch directly for the time being but I think it'd be great if you could fix the conflicts, too. :) |
|
@svenstaro I've merged |
|
Super noice! Will check it out. |
Includes fix for issue #14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the fairing compatible with the asynchronous version of Rocket. This won't be merged until async Rocket is released.