Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an optional request filter for PrometheusMetrics #23

Merged
merged 2 commits into from
May 20, 2024
Merged

Add an optional request filter for PrometheusMetrics #23

merged 2 commits into from
May 20, 2024

Conversation

Eijebong
Copy link
Contributor

This will allow users to filter out some requests from metrics, namely requests to /metrics

Fixes #22

@Eijebong
Add an optional request filter for PrometheusMetrics
04be8f5 
This will allow users to filter out some requests from metrics, namely
requests to `/metrics`

Fixes sd2k#22
sd2k
sd2k reviewed May 20, 2024
View reviewed changes
Copy link
Owner

@sd2k sd2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for the contribution!

Would you mind updating the integration test in tests/integration.rs to add a client call to /metrics and adding a filter on to match that call, and asserting that the metrics text is unchanged?

@sd2k sd2k merged commit d40fc58 into sd2k:main May 20, 2024
@sd2k
Copy link
Owner

sd2k commented May 20, 2024

Perfect, thanks 👍

@sd2k
Copy link
Owner

sd2k commented May 20, 2024

Released in v0.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sd2k sd2k sd2k left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is there a way to exclude /metrics from the reporting
2 participants
@Eijebong @sd2k