-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filename Error when downloading #138
Comments
Another weird title I found that fails is Search MyAnimeList for anime in Season? (y|n):
Current: hanayome
Downloading: 5-toubun no Hanayome∽ EP: 1 - hls |
Okay, so basically it looks like anipy-cli is trying to save the file as the exact name for the anime, but some OS's don't support the characters being written (tab key, or tilda). I'll go ahead and see if I can fix it and make a pull request if I can. Thanks for the highlight! |
That would be nice. We already have a function that takes care of cleaning filenames in download.py. what you could do is to get rid of Unicode chars by encoding it to ASCII, something like that : |
Describe the bug
When downloading "Violet Evergarden Gaiden: Eien to Jidou Shuki Ningyou" this error would occur:
OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: 'C:\Users\raymo\Documents\GitHub\anipy-cli\anipy_cli\download\Violet Evergarden Gaiden Eien to Jidou Shuki Ningyou\t'
To Reproduce
Steps to reproduce the behavior:
C:\Windows\System32>
Expected behavior
File would download
Info
Name: anipy-cli
Version: 2.7.22
Summary: Little tool in python to watch anime from the terminal (the better way to watch anime)
Home-page: https://github.com/sdaqo/anipy-cli
Author: sdaqo
Author-email: sdaqo.dev@protonmail.com
License: GPL-3.0
Location: C:\Users\raymo\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages
Requires: beautifulsoup4, better-ffmpeg-progress, m3u8, moviepy, pycryptodomex, pypresence, python-dateutil, python-mpv, pyyaml, requests, setuptools, tqdm
Required-by:
Platform
Additional context
Seems to occur only with this title. All other titles I've tried work fine.
The text was updated successfully, but these errors were encountered: