Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config system should be changed so that people don't have to update their personal config everytime an option is added #79

Closed
VoidAny opened this issue Aug 15, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@VoidAny
Copy link
Contributor

VoidAny commented Aug 15, 2022

Right now, every time a config option is added, users are expected to manually go update their config_personal.py file with the new option that was added to continue to be able to use the program. I think that this project should use a config system where there are 2 config files: a defaults one and one that stores the user changed options.

All of the default options are stored in the default config file and then users can manually go through and add every option they want changed into the custom config file with the updated value.

This would solve the issue of new config options breaking the program and the messy code required to use a hard-coded default in case a config option is not set.

@sdaqo sdaqo added the enhancement New feature or request label Aug 15, 2022
sdaqo added a commit that referenced this issue Aug 15, 2022
@sdaqo
Copy link
Owner

sdaqo commented Aug 15, 2022

Ok done now, I made a yaml config, look in the readme for instructions

@sdaqo sdaqo closed this as completed Aug 15, 2022
@sdaqo sdaqo reopened this Aug 15, 2022
@sdaqo
Copy link
Owner

sdaqo commented Aug 15, 2022

If you find any errors please report

@VoidAny
Copy link
Contributor Author

VoidAny commented Aug 16, 2022

There were many issues. You should really test your code and make sure it works. Anyways, I fixed them all in #80

@sdaqo
Copy link
Owner

sdaqo commented Aug 16, 2022

You should really test your code and make sure it works.

You are right... I should also write some automated tests.

@sdaqo sdaqo closed this as completed Aug 16, 2022
@amazoedu0
Copy link

amazoedu0 commented Aug 18, 2022

Respected Dev(s)
Greetings.
I'm getting these errors kindly guide me. I have created config file but still getting these errors my OS is MS Windows 10.
C:\Users\Pc Planet>anipy-cli Traceback (most recent call last): File "C:\Users\Pc Planet\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main return _run_code(code, main_globals, None, File "C:\Users\Pc Planet\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code exec(code, run_globals) File "C:\Users\Pc Planet\AppData\Local\Programs\Python\Python310\Scripts\anipy-cli.exe\__main__.py", line 4, in <module> File "C:\Users\Pc Planet\AppData\Local\Programs\Python\Python310\lib\site-packages\anipy_cli\__init__.py", line 16, in <module> from .query import query File "C:\Users\Pc Planet\AppData\Local\Programs\Python\Python310\lib\site-packages\anipy_cli\query.py", line 9, in <module> base_url = Config().gogoanime_url File "C:\Users\Pc Planet\AppData\Local\Programs\Python\Python310\lib\site-packages\anipy_cli\config.py", line 12, in __init__ self._config_file = self._get_config_path() / "config.yaml" File "C:\Users\Pc Planet\AppData\Local\Programs\Python\Python310\lib\site-packages\anipy_cli\config.py", line 131, in _get_config_path raise SysNotFoundError(platform) anipy_cli.config.SysNotFoundError: win32

@VoidAny
Copy link
Contributor Author

VoidAny commented Aug 18, 2022

This was recently fixed in the latest update. To update, run python -m pip install --upgrade anipy-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants