This repository has been archived by the owner on Mar 14, 2023. It is now read-only.
Added functionality to simplify the initialisation of the wrapper. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were primarily to facilitate Shared iPad support.
| @@ -134,6 +134,20 @@ | |||
| */ | |||
| +(void)removeNotifications; | |||
|
|
|||
| #define ICLOUD_DATA_ENABLED_KEY @"iCloudDataEnabled" | |||
There was a problem hiding this comment.
I'd prefer constants to be defined using the extern NSString* const syntax, so the actual value can be hidden in the .m file. (See here for an example.)
|
Incidentally, I deliberately left calling synchronise to the host app as it's not quite as simple as "more often is better." When using the iCloud version, calls get throttled if you use it too often, which results in the save happening less often. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were primarily to facilitate Shared iPad support.
I've also set the synchronize to happen more often because the delay was too great (IMO).