Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme color per instance #435

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

theme color per instance #435

wants to merge 2 commits into from

Conversation

fichl
Copy link
Contributor

@fichl fichl commented Feb 6, 2024

re-enabled Olis already implemented theme color picker in help screen
and made the selected color save per NAM instance.

individual colors will stick after reload reaper project.

Screenshot 2024-02-06 020725

@olilarkin
Copy link
Contributor

Nice... it is also possible to use the track colour via this API: https://github.com/iPlug2/iPlug2/blob/a2bd8743851590db5e302f7a814dfe07224d1e1a/IPlug/IPlugAPIBase.h#L121

@sdatkinson sdatkinson self-assigned this Feb 6, 2024
@sdatkinson
Copy link
Owner

Fun! I'm open to merging this.

Before I do / as part of the next release, I'm keen to take @olilarkin's advice and serialize the plugin version (just made #436, can't remember where I saw it originally).

So hang tight and I'll try to get to this soon.

@fichl
Copy link
Contributor Author

fichl commented Feb 7, 2024

@olilarkin thats a cool feature :). i already got it working using:

int r, g, b; GetTrackColor(r, g, b); if (r != 0 && g != 0 && b != 0) // is default color set in DAW ? NAM_CUSTOMTHEMECOLOR = IColor(255, r, g, b);

but using it inside OnUIOpen it obviously only applies a newly selected track color when NAM window is closed and reopened.
using it inside OnIdle costs around 11MB etra RAM which isnt good either...

do you have any advise on where to use it best ?
it would be nice if it would change the themecolor the moment i change the track color....

@sdatkinson
Copy link
Owner

I'll ask let's not do the track color bit for this PR--better chance of shipping it successfully 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants