Skip to content
This repository has been archived by the owner on Feb 3, 2018. It is now read-only.

Provide method for filtering stdlib from PackageTree imports #113

Closed
sdboyer opened this issue Nov 30, 2016 · 1 comment
Closed

Provide method for filtering stdlib from PackageTree imports #113

sdboyer opened this issue Nov 30, 2016 · 1 comment
Assignees
Milestone

Comments

@sdboyer
Copy link
Owner

sdboyer commented Nov 30, 2016

Working on the new dep tool has made it quite painfully clear that the PackageTree methods are really, really narrowly tailored to the solver's needs.

For one - stdlib imports are included in the returns from ListPackages(), and there's no way for dependers to pull them out themselves. In a sense, this is intentional - I'm not fully comfortable with my strategy of just literally listing out the stdlib packages (and others) in source code, so I didn't want to expose it publicly. But it's crunch time now, and it seems pretty clear that a more comprehensive solution is quite involved, so it's time to expose that information.

@sdboyer
Copy link
Owner Author

sdboyer commented Jan 10, 2017

Note - the underpinnings here are a little different, now:

I'm not fully comfortable with my strategy of just literally listing out the stdlib packages (and others) in source code,

That hardcoded list no longer exists. It's been replaced with an isStdlib() func (#118) that's used to determine if an import path points to stdlib (and is the same implementation as what the go toolchain uses).

@sdboyer sdboyer added this to the v0.14.0 milestone Jan 28, 2017
sdboyer added a commit that referenced this issue Feb 13, 2017
Much better name. Also adds the capability of filtering out stdlib from
PackageTree imports, addressing #113.
sdboyer added a commit that referenced this issue Feb 13, 2017
Much better name. Also adds the capability of filtering out stdlib from
PackageTree imports, addressing #113.
krisnova pushed a commit to krisnova/dep that referenced this issue Apr 21, 2017
Much better name. Also adds the capability of filtering out stdlib from
PackageTree imports, addressing sdboyer/gps#113.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant