sddm-helper creates random name dirs in $HOME

[vladsol]

Issue with sddm-helper
Fedora 29, x86_64
sddm 0.18.0

sddm/src/helper/UserSession.cpp

Line 237 in c8867e0

.arg(QString::fromLocal8Bit(pw.pw_dir))

At this point, pw.pw_dir becomes garbage.
The reason is:

sddm/src/helper/UserSession.cpp

Line 230 in c8867e0

free(buffer);

[vladsol]

Code to test this behavior:

#include <stdio.h>
#include <pwd.h>
 
int main()
{
    struct passwd pw;
    struct passwd *rpw;
    long bufsize = 16384;
    char *buffer = (char *)malloc(bufsize);
    getpwnam_r("user_name", &pw, buffer, bufsize, &rpw);
    printf("before: %s\r\n", pw.pw_dir);
    free(buffer);
    printf("after: %s\r\n", pw.pw_dir);
    return 0;
}

error checkings is omitted for simplicity.

[davidedmundson]

Please check dev branch works for you.

Pier, if you're free could you cherry pick my commit and make a release?

[vladsol]

Please check dev branch works for you.

Looks like it should work :)

[plfiorini]

@davidedmundson Ok but I think your commit is already in develop, so I will just merge develop into master and make a release

[davidedmundson]

It is in develop. Up to you whether we do a full release or patch release. David

…

On Sat, 9 Mar 2019, 22:54 Pier Luigi Fiorini, ***@***.***> wrote: @davidedmundson <https://github.com/davidedmundson> Ok but I think your commit is already in develop, so I will just merge develop into master and make a release — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1145 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACpcDZ7u0dUbSpgbHUT160FXy_LaZ2mcks5vVC2jgaJpZM4bmxM6> .

[plfiorini]

OK I will make a 0.18.1 hotfix release this week.

[Vogtinator]

Resolved a while ago.