-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in elarun theme #1336
Error in elarun theme #1336
Conversation
this error: file:///usr/share/sddm/themes/debian-theme/Main.qml:155: ReferenceError: session_button is not defined session_button was removed in sddm#521
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
session_button may be removed, but this surely leaves tab/backtab on those two buttons broken.
Shouldn't it point to the next button in the chain instead of removing it?
Thanks for the review. The two broken buttons now have both tab/backtab references. |
* session_button for the elarun theme is undefined, raising this error: file:///usr/share/sddm/themes/debian-theme/Main.qml:155: ReferenceError: session_button is not defined session_button was removed in sddm#521
* session_button for the elarun theme is undefined, raising this error: file:///usr/share/sddm/themes/debian-theme/Main.qml:155: ReferenceError: session_button is not defined session_button was removed in sddm#521
* session_button for the elarun theme is undefined, raising this error: file:///usr/share/sddm/themes/debian-theme/Main.qml:155: ReferenceError: session_button is not defined session_button was removed in sddm#521
* session_button for the elarun theme is undefined, raising this error: file:///usr/share/sddm/themes/debian-theme/Main.qml:155: ReferenceError: session_button is not defined session_button was removed in sddm#521
Fixes #1272
When running sddm with elarun in Debian I get the following (seemingly innocuous) error message:
file:///usr/share/sddm/themes/debian-theme/Main.qml:155: ReferenceError: session_button is not defined
The button in question was removed in #521
I have removed the references in my local branch:
mvlvrd/sddm@1283919
and run it without issue.