Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in elarun theme #1336

Merged
merged 4 commits into from Mar 14, 2021
Merged

Error in elarun theme #1336

merged 4 commits into from Mar 14, 2021

Conversation

mvlvrd
Copy link
Contributor

@mvlvrd mvlvrd commented Nov 29, 2020

Fixes #1272

When running sddm with elarun in Debian I get the following (seemingly innocuous) error message:

file:///usr/share/sddm/themes/debian-theme/Main.qml:155: ReferenceError: session_button is not defined

The button in question was removed in #521

I have removed the references in my local branch:
mvlvrd/sddm@1283919
and run it without issue.

mvlvrd and others added 2 commits July 5, 2020 17:07
this error:
file:///usr/share/sddm/themes/debian-theme/Main.qml:155: ReferenceError: session_button is not defined

session_button was removed in sddm#521
Copy link
Collaborator

@Pointedstick Pointedstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@davidedmundson davidedmundson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

session_button may be removed, but this surely leaves tab/backtab on those two buttons broken.

Shouldn't it point to the next button in the chain instead of removing it?

@mvlvrd
Copy link
Contributor Author

mvlvrd commented Dec 13, 2020

Thanks for the review. The two broken buttons now have both tab/backtab references.

@plfiorini plfiorini dismissed davidedmundson’s stale review March 14, 2021 07:07

changes requested were made

@plfiorini plfiorini merged commit 191698e into sddm:develop Mar 14, 2021
aleixpol pushed a commit to aleixpol/sddm that referenced this pull request Mar 19, 2021
* session_button for the elarun theme is undefined, raising
this error:
file:///usr/share/sddm/themes/debian-theme/Main.qml:155: ReferenceError: session_button is not defined

session_button was removed in sddm#521
davidedmundson pushed a commit to davidedmundson/sddm that referenced this pull request Mar 21, 2021
* session_button for the elarun theme is undefined, raising
this error:
file:///usr/share/sddm/themes/debian-theme/Main.qml:155: ReferenceError: session_button is not defined

session_button was removed in sddm#521
peremen pushed a commit to peremen/sddm that referenced this pull request Jun 30, 2022
* session_button for the elarun theme is undefined, raising
this error:
file:///usr/share/sddm/themes/debian-theme/Main.qml:155: ReferenceError: session_button is not defined

session_button was removed in sddm#521
githubkusi pushed a commit to githubkusi/sddm that referenced this pull request Jul 6, 2023
* session_button for the elarun theme is undefined, raising
this error:
file:///usr/share/sddm/themes/debian-theme/Main.qml:155: ReferenceError: session_button is not defined

session_button was removed in sddm#521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in elarun theme
4 participants