Remove title bar under Weston (and possibly others) #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't run sddm using Weston's fullscreen-shell.so (black screen, is it only me or is it a known bug?) Changing the compositor command line to just "weston" works, but it draws a title bar, and since Weston only supports client-side decorations it's apparently sddm's task to do this. Not sure if it breaks something under X11 (seems like it shouldn't). I'm new to sddm, let alone to C++. It's working for me, so I'm making this PR in case this it's actually the way to go.
plfiorini
approved these changes
Jun 8, 2021
peremen
pushed a commit
to peremen/sddm
that referenced
this pull request
Jun 30, 2022
Make sure the greeter doesn't have a title bar. This is especially useful on Wayland when the fullscreen shell protocol is not used.
githubkusi
pushed a commit
to githubkusi/sddm
that referenced
this pull request
Jul 6, 2023
Make sure the greeter doesn't have a title bar. This is especially useful on Wayland when the fullscreen shell protocol is not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't run sddm using Weston's fullscreen-shell.so (black screen, is it only me or is it a known bug?) Changing the compositor command line to just "weston" works, but it draws a title bar, and since Weston only supports client-side decorations it's apparently sddm's task to do this. Not sure if it breaks something under X11 (seems like it shouldn't). I'm new to sddm, let alone to C++. It's working for me, so I'm making this PR in case this it's actually the way to go.