Address privilege dropping #1449
Conversation
aleixpol
force-pushed
the
fix_priv_drop
branch
from
ac15f8b
to
1c9470c
Compare
|
It's a definite major regression that needs fixing before release. Direction wise, I don't think we have a choice, so ++ Review wise, I think we can squash a lot of these commits. |
aleixpol
force-pushed
the
fix_priv_drop
branch
from
c4187c0
to
2ba775b
Compare
This reverts commit 4c99b78.
Or otherwise all information gets lost.
* Wait a bit longer for non-greeter sessions in case they need to wrap the session up * Wait again after killing
aleixpol
force-pushed
the
fix_priv_drop
branch
from
2ba775b
to
725e312
Compare
|
@davidedmundson addressed your comments, I didn't fold the changes into where they were added for the cases where it was coming from the reverted code. |
|
This PR seems to break login for rootless X11. I got the following error from
|
Would you be able to create an issue and provide how you have it configured so I can reproduce and address it? |
|
Ah, someone beats me :) #1456 |
Our sddm-helper needs to stay a root process as it's in charge of dealing with PAM. Alternatively the pam calls in PamBackend will fail.
To do so, we get helper processes to run xorg+greeter for x11-user and wayland-compositor+greeter for wayland. Obviously for general x11 don't need a helper as it runs as root.