Fix SDDM hanging when shutting down Plasma Wayland session #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SignalHandler::initialize() must be called otherwise signals won't be processed and helpers can crash when they receive SIGTERM.
If xorg stops, sddm will try to create a new display, however this can create issues at shutdown where systemd tries to kill all processes in the cgroup. This change changes the kill mode of sddm to mixed. With that mode, sddm will be able to terminate the display itself. If sddm fails to do so within reasonable interval, systemd will start killing processes in the cgroup.
If sddm-helper misbehaves at shutdown, e.g. crashes, sddm may try to restart display, which can end up in shutdown getting stuck.
zzag
force-pushed
the
work/zzag/wayland-shut-down
branch
from
94e2830
to
3485204
Compare
When the computer shuts down, sddm can try to restart Xorg and hang when reading the display from Xorg. This change intends to mitigate that issue by making sddm delaying stopping display if the sddm-helper's exit code is not 0. If the exit code is 0, the user has most likely logged out, and therefore it should be relatively safe to restart display. Otherwise wait a second before attempting to restart display.
zzag
force-pushed
the
work/zzag/wayland-shut-down
branch
from
3485204
to
1204ef8
Compare
|
@zzag Here are couple errors found when building from git with PRs 1489, 1494, 1506, 1511 |
|
I looked into rebasing these before I just built 'develop' to find my issue resolved - I'm not sure that this fix needs to be applied (but may still be valuable). Those errors can easily be fixed by dropping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the sddm-helper receives SIGTERM or the session process terminates
with non zero exit code, delaying restarting display.
The main issue with restarting display at shutdown is that sddm can hang
when trying to get display from Xorg. This is the main reason why shutdown
takes so long with plasma wayland session.
fixes #1476