Fix crash on Square Terminal refund

Also speculative fix for #249 on github
sde1000 · May 26, 2023 · 20e15be · 20e15be
1 parent b352ffb
commit 20e15be
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/quicktill/squareterminal.py b/quicktill/squareterminal.py
@@ -749,8 +749,12 @@ def update(self):
         p.text = f"{p.paytype.description} refund {refund.id[:6]}"
         p.amount = -refund.amount_money.as_decimal()
         p.pending = False
+        td.s.flush()
         self.register.payments_update()
-        td.s.commit()  # Ensure refund committed even if orig update failes
+        # Ensure refund committed even if orig update failed
+        td.s.commit()
+        # _update_original_payment requires self.session, which is deleted
+        # by self.dismiss()
         self._update_original_payment(op)
         self.dismiss()