Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit sent messages #193

Open
sibartlett opened this issue Feb 5, 2015 · 19 comments
Open

Edit sent messages #193

sibartlett opened this issue Feb 5, 2015 · 19 comments
Labels
Milestone

Comments

@sibartlett
Copy link
Contributor

Would be nice to have the ability to correct typos.

This involves rewriting history though.

@geoffwhittington
Copy link
Contributor

He who controls the past ... 👍

@PerfectCarl
Copy link

I'm so bad at typing that this feature would free me and make my time chatting more enjoyable.

:)

@geoffwhittington
Copy link
Contributor

I'm not clear how this feature would work in practice. There is a likely risk that follow-up messages will look out-of-context.

My suggestion is the introduction of a delay before a message is actually sent - so you can review it and fix it.

@funkaoshi
Copy link
Contributor

I think it's best not to do this. It sort of runs contrary to how most people assume chat works.

@hhaidar
Copy link
Member

hhaidar commented Feb 16, 2015

I want this feature in, but with two notes:

  • Some type of time limit
  • Messages have some indicator they were changed (like a * next to the time or something)

@sibartlett
Copy link
Contributor Author

Skype allows you edit messages you've already sent - could look at that an example.

@Zash
Copy link

Zash commented Feb 16, 2015

This may be of use: XEP-0308: Last Message Correction

@funkaoshi
Copy link
Contributor

Might want to keep a history of edits, so people can see what was changed.

@hhaidar
Copy link
Member

hhaidar commented Feb 16, 2015

@funkaoshi Nice to have, not a deal breaker though imo

@PerfectCarl
Copy link

This feature has been implemented in skype, whatsapp and that other group chat web app to the users' benefits
(I don't remember any backlash from their user base regarding that feature)

@funkaoshi funkaoshi modified the milestone: Backlog Feb 18, 2015
@powange
Copy link

powange commented Feb 20, 2015

This feature has been implementedin Slack :)

+1

@hany
Copy link

hany commented Apr 27, 2015

Just a quick note here that some regulations require a full log for any chat system used. Having the ability to edit past messages, especially with no audit trail, will be a deal-breaker for those needing to follow such regulations.

@Zash
Copy link

Zash commented Apr 29, 2015

The XEP referenced above is just a piece of metadata that says "this message replaces that message". You don't need to actually delete the old message, just keep some metadata that you should display another instead.

@JonathanWeinstein
Copy link

+1 this feature is actually getting pretty common in chat apps, would love to see it here

@nicolas-raoul
Copy link

+1 This is what is preventing our company from switching from Slack to Let's Chat.

It could be disabled by a server-side setting for the rare cases where this feature might be unwanted.
Slack allows to edit even very old messages. Some other systems have a time limit (StackExchange chat I think).

@digination
Copy link
Contributor

+1 This feat. would be awesome.

@janstieler
Copy link

+1 I wrote so many times wrong words because I type too fast. It would be a necessary function for me.

@Frankstar
Copy link

rocket.chat has this feature and i hate it most of the time.
So many messages look out-of-context if you read them later.

If you add this feature we also need the feature to delete messages. (why istn this even in yet ? or im i blind)

i would more love a "you have 30seconds to change" option. But not change "forever"

@TacticalTux
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests