New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dateFormat option #43
Conversation
I removed my name from the authors list because it was such a small change, if it didn't get removed you can remove it. |
Hi @rdallaire, thanks for the PR :) I'm fine with having your name on the authors list! |
@sdepold Yes, I can look into adding a test. I am fairly new to testing but I will take a look at it. |
It should be fairly easy to adopt the existing tests (if they still work :D). |
Yeah I will duplicate one of them and moddify it. |
Well that is done on purpose but feel free to change it if needed |
Why did you close this PR ? |
I messed with the test briefly and did not get it to work. I was unsure how to add the test for a 3rd party plugin |
I see. If you rebase the branch I can also add the test on my own. :) |
Rebase pls. |
use the compiler.jar to create to proper closures, so I removed the extra semicolons to be consistant
I updated it. I also removed the semicolon closures realizing that the compiler does it. The example also uses a CDN for moment.js as bower_components isn't stored in the repo. |
👍 |
Released as 1.5.0. Thanks a lot! |
Added an option to format the date with moment.js.