Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dateFormat option #43

Merged
merged 17 commits into from Feb 7, 2015
Merged

Add dateFormat option #43

merged 17 commits into from Feb 7, 2015

Conversation

rdallaire
Copy link
Contributor

Added an option to format the date with moment.js.

@rdallaire
Copy link
Contributor Author

I removed my name from the authors list because it was such a small change, if it didn't get removed you can remove it.

@sdepold
Copy link
Owner

sdepold commented Jan 6, 2015

Hi @rdallaire,

thanks for the PR :) I'm fine with having your name on the authors list!
Any chance of adding a test?

@rdallaire
Copy link
Contributor Author

@sdepold Yes, I can look into adding a test. I am fairly new to testing but I will take a look at it.

@sdepold
Copy link
Owner

sdepold commented Jan 7, 2015

It should be fairly easy to adopt the existing tests (if they still work :D).

@rdallaire
Copy link
Contributor Author

Yeah I will duplicate one of them and moddify it.
@sdepold Looking at the code on my sublime text with JSlint it appears that a lot of lines are missing semicolons at the end? Is this right or am I missing something. I was having issues with a concat/ minfier and that appeared to be the issue

@sdepold
Copy link
Owner

sdepold commented Jan 7, 2015

Well that is done on purpose but feel free to change it if needed

@rdallaire rdallaire closed this Jan 9, 2015
@sdepold
Copy link
Owner

sdepold commented Jan 12, 2015

Why did you close this PR ?

@rdallaire rdallaire reopened this Jan 12, 2015
@rdallaire
Copy link
Contributor Author

I messed with the test briefly and did not get it to work. I was unsure how to add the test for a 3rd party plugin

@sdepold
Copy link
Owner

sdepold commented Jan 12, 2015

I see. If you rebase the branch I can also add the test on my own. :)

@sdepold
Copy link
Owner

sdepold commented Feb 3, 2015

Rebase pls.

@rdallaire
Copy link
Contributor Author

I updated it. I also removed the semicolon closures realizing that the compiler does it.

The example also uses a CDN for moment.js as bower_components isn't stored in the repo.

@sdepold
Copy link
Owner

sdepold commented Feb 7, 2015

👍

sdepold added a commit that referenced this pull request Feb 7, 2015
@sdepold sdepold merged commit 4b8d7b8 into sdepold:gh-pages Feb 7, 2015
@sdepold
Copy link
Owner

sdepold commented Feb 7, 2015

Released as 1.5.0. Thanks a lot!

This was referenced May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants