Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI, convert to Arduino library #1

Merged
merged 3 commits into from Jun 29, 2021

Conversation

ianfixes
Copy link
Contributor

@ianfixes ianfixes commented Jan 25, 2018

I'm working on a library that allows you to run unit tests and compiling examples on Travis CI. I'm using your project to shake some of the bugs out of my implementation, so I'm contributing my edits in case you think they would be useful.

Since you don't have Travis CI enabled for this repository, you'll have to peek at mine to see the results:
https://travis-ci.org/ianfixes/Arduino-Queue.h/builds

@ianfixes ianfixes force-pushed the 2018-01-25_ci branch 6 times, most recently from 13a752d to 0ece896 Compare January 25, 2018 19:27
@ianfixes ianfixes force-pushed the 2018-01-25_ci branch 2 times, most recently from 44306e7 to 9e24ddb Compare March 7, 2018 21:17
library.properties Outdated Show resolved Hide resolved
@sdesalas
Copy link
Owner

sdesalas commented Jun 29, 2021

Hi @ianfixes, this just popped up on my radar... Is it still good to merge?

BTW sorry for the long delay, I though it was someone random trying to add build scripts to my project, but I see you're involved with library QA for @Arduino-CI project.

@sdesalas sdesalas merged commit 3952408 into sdesalas:master Jun 29, 2021
@sdesalas
Copy link
Owner

sdesalas commented Jun 29, 2021

Hi @ianfixes, I see some memory leak errors in travis CI, but I'm not sure if its because of the tests (queue instances are not being disposed of), or the ci framework or the actual library.

Greatful if you could take a look:

https://travis-ci.com/github/sdesalas/Arduino-Queue.h

Thanks!!

image

@ianfixes
Copy link
Contributor Author

Hahaha this is a blast from the past! I thought the project had been abandoned or something, and put it out of my mind.

I though it was someone random trying to add build scripts to my project

At the time, that's exactly what was happening! 😂 I used your queue library as a guinea pig for being able to write my unit testing library, and contributed the result.

The error happening here looks like a segfault, which the library uses libasan to annotate. If I had to guess, it could be that between the initial implementation of my library and the version that exists now are conflicting over an internal Queue class that I added. I will have to give this a run locally and see what the latest version of arduino_ci comes up with.

@sdesalas
Copy link
Owner

sdesalas commented Jul 1, 2021

No worries, I'll take a look at the tests too when i get a chance.

I have a feeling that setting queue = null; or delete queue; after each test might do the trick to release the memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants