Settings page added #133

Nppatel97 · 2019-06-07T02:54:24Z

New Settings page made. @AhmedNSidd if you can add a link or something for this so I can view this page while modifying, that would be dope! Also, there are only two settings that I am aware of right? To honor or not honor availability and ability to reschedule. Also, this is literally just a copy pasta code of agenda.html so I haven't changed anything except the title which says 'Settings | Schedulearn'.

sdevalapurkar

Looks good to me, but I wonder if there is any way to share code/reuse components from existing files instead of copy 🍝 code... any thoughts?

Nppatel97 · 2019-06-08T01:28:41Z

Looks good to me, but I wonder if there is any way to share code/reuse components from existing files instead of copy 🍝 code... any thoughts?

That's a great idea! We can make a skeleton file and reuse it in all other files but it would be kinda difficult to do in HTML.. Something like React would be awesome for that. Or if there is some feature in Python or JS that I may not be aware of

AhmedNSidd · 2019-06-12T00:09:25Z

I am actually working on a branch right now that's doing something similar to what you're asking @sdevalapurkar. Specifically, it's setting up css files that are generic to all pages to minimize reuse of code. It's taking some time to work on it because there's a lot of variability across the css files. In the future, we can also work on creating base html files that contain maybe only the navbar and the other html files can extend that base html. Anyway @Nppatel97, I pushed some code up that has set up the routing for the settings page. So you can see the page now at http://localhost:8000/dashboard/settings/
If you have any questions lmk

EDIT: also yes, there's only two options that I need you to add right now #120 and #123

Nppatel97 · 2019-06-19T09:36:13Z

Alright guys, Settings page is complete with all the links and options in place. My Profile link is moved to primary navbar and is replaced by settings. Will have to do this in all other files though. Now just need to add the back-end logic to this. Here are some images. Let me know what you think and any changes that it might need @AhmedNSidd @sdevalapurkar @DSchriemer :)

AhmedNSidd · 2019-06-19T13:00:36Z

That looks absolutely fantastic man. Exactly how I wanted it to look. GREAT job. Although for the setting titles, I think we should capitalize the first letter of each word. After work, I'm gonna get home and check out how this looks in the browser and start implementing some of the backend into this

sdevalapurkar · 2019-06-19T18:18:30Z

schedule_lessons/dashboard/static/dashboard/js/settings.js

@@ -0,0 +1,11 @@
+$(document).ready(function () {


can we use ES6 style arrow functions here?

$(document).ready(() => { });

schedule_lessons/dashboard/urls.py

sdevalapurkar · 2019-06-19T18:20:40Z

schedule_lessons/dashboard/views.py

+    notifications = Notification.objects.filter(
+        user=request.user).order_by("-created_on")
+    context = {
+        "notifications": []


question: how come context doesn't have a property called unread_notifications even tho it is being used later on?

True actually, I opened up issue #139 about this so we can clean this up later since there are other instances where I do this in this file.

AhmedNSidd

I had a chance to look at this after work. I have a few comments on things that can be improved a bit. Firstly I think the Settings Title in the webpage should be bigger (maybe make it h3 or even bigger, use your best judgement). Make the setting names and descriptions relatively bigger too (idk if you made them small so it looks better on mobile, if that's the case, let me know).

I think for the future of the settings page, I wanna move the "Blocked Users", "Change Password", and "Delete Account" options from the profile page to the settings page. It's not something I think we should do in this PR but maybe we should setup issues to tackle these issues in future versions (or if we get the chance, v1.0).

DSchriemer · 2019-06-20T01:43:52Z

Looking very good, nice work!!

Nppatel97 · 2019-06-20T02:57:04Z

I had a chance to look at this after work. I have a few comments on things that can be improved a bit. Firstly I think the Settings Title in the webpage should be bigger (maybe make it h3 or even bigger, use your best judgement). Make the setting names and descriptions relatively bigger too (idk if you made them small so it looks better on mobile, if that's the case, let me know).

I think for the future of the settings page, I wanna move the "Blocked Users", "Change Password", and "Delete Account" options from the profile page to the settings page. It's not something I think we should do in this PR but maybe we should setup issues to tackle these issues in future versions (or if we get the chance, v1.0).

Yeah I wanted to make them look consistent with the text in navbars so I chose these sizes for Settings title and options. I'll fiddle around with sizes and see which ones look better on both mobile and desktop.

And yes, I think those options would be better in settings (than in my profile page), I think it could be easy to do it in v1.0 as long as there is not much back-end logic involved. (Maybe even in this PR?)

Nppatel97 · 2019-06-20T02:57:58Z

Looking very good, nice work!!

Thanks! Let me know if you have any ideas on improving this UI/UX :)

Nppatel97 · 2019-06-29T08:40:20Z

I have updated all the navbar links so now they all show my profile in primary navbar and settings under profile pic. Also moved the change password, blocked users and delete account options to the settings page. Not sure how it connects to the back-end so I am leaving that for @AhmedNSidd.

Also, the secondary navbar of public_profile.html has not been optimized by me in past because there are a lot (a lotttt) of if-else django stuff in it as shown in the image ↓

Check the lastest commit and let me know of any bugs or if I missed anything. Cheers! 🍻

EDIT: Ooo and about making the headers a little bigger, I tried to fiddle around with different sizes and it looked a little inconsistent and odd so I kept it the way it was.

AhmedNSidd · 2019-06-29T14:42:35Z

@Nppatel97 Please check out this latest commit and make sure it looks alright. I used the chrome coverage tool to get rid of any unused css/js code for the settings page.

EDIT: Also thanks for moving the buttons to the settings page, they look good. However, in a future commit, I wanna move them down and maybe remove the extended navbar. It looks good for now, I'll just implement the backend logic now, it should be easy enough to move them down later.

…ed users, and deleting an account to the settings page

AhmedNSidd · 2019-06-29T17:50:50Z

schedule_lessons/dashboard/static/dashboard/css/agenda.css

 /* END Navbar for logged in Users */

 #picturePrompt {
-  height: 300px;
+  width: 90%;


I am guessing you made this change to look better on mobile, but the image was too huge on laptop. Please check out my commit on "Fixing the huge picture prompt" and let me know if the changes I made look alright

sdevalapurkar

nice work, some stuff to clean up a bit and some small nits/suggestions but overall looks good

schedule_lessons/dashboard/static/dashboard/js/settings.js

sdevalapurkar · 2019-06-30T06:02:17Z

schedule_lessons/dashboard/static/dashboard/js/settings.js

+
+$.ajaxSetup({
+  beforeSend: function (xhr, settings) {
+    if (!(/^http:.*/.test(settings.url) || /^https:.*/.test(settings.url))) {


not sure what is being checked in this if statement, could you please clarify, thanks!

I changed the if condition, let me know if the new one makes sense to you.

…ttings-page-added

sdevalapurkar

the js changes LGTM, one minor comment

schedule_lessons/dashboard/static/dashboard/js/settings.js

…the rescheduling preference for tutors

sdevalapurkar

js tips and tricks

sdevalapurkar · 2019-07-18T04:02:22Z

schedule_lessons/dashboard/static/dashboard/js/settings.js

@@ -55,6 +55,15 @@ $(document).ready(() => {
      });
    }
  });
+
+  $(".preference").click((event) => {
+    const preference_id = event.target.id;


since we are only using a few properties of this event object, let's try this:

const { id, checked } = event.target;

and then use id and checked

sdevalapurkar · 2019-07-18T04:03:07Z

schedule_lessons/dashboard/static/dashboard/js/settings.js

+    const preference_id = event.target.id;
+    $.ajax({
+      type: "POST",
+      url: "/dashboard/modify_preference/" + preference_id + "/",


url: /dashboard/modify_preference/${id}/

use the string template literal syntax

Settings page added

settings page added

48a8ad4

Nppatel97 requested review from DSchriemer, sdevalapurkar and AhmedNSidd June 7, 2019 02:54

sdevalapurkar reviewed Jun 7, 2019

View reviewed changes

AhmedNSidd changed the title ~~settings page added~~ [WIP] settings page added Jun 12, 2019

Add backend logic for the settings page by setting up routing

ed1641f

AhmedNSidd force-pushed the settings-page-added branch from 87a61a9 to ed1641f Compare June 12, 2019 00:26

Nppatel97 added 2 commits June 15, 2019 16:55

basic layout added

9cd95c6

settings page complete

016c2d8

sdevalapurkar reviewed Jun 19, 2019

View reviewed changes

ES6 functions, capitalized options

e0578b6

AhmedNSidd requested changes Jun 20, 2019

View reviewed changes

all navbars updated

ba8ff8e

Nppatel97 requested review from sdevalapurkar and AhmedNSidd June 29, 2019 08:43

Remove unused css/js code

700f3f6

AhmedNSidd added 3 commits June 29, 2019 11:01

Port over the modal styling code to settings.css

7b310a5

Port over backend functionality for changing passwords, viewing block…

2b475b9

…ed users, and deleting an account to the settings page

Fix huge agenda picture prompt

fc7557d

AhmedNSidd reviewed Jun 29, 2019

View reviewed changes

sdevalapurkar requested changes Jun 30, 2019

View reviewed changes

AhmedNSidd mentioned this pull request Jul 1, 2019

Add frontend form validation wherever possible #141

Open

AhmedNSidd added 2 commits July 11, 2019 21:27

Improve setting.js code

a07cbfa

Merge branch 'master' of github.com:sdevalapurkar/schedulearn into se…

74f14c8

…ttings-page-added

sdevalapurkar reviewed Jul 12, 2019

View reviewed changes

schedule_lessons/dashboard/static/dashboard/js/settings.js Outdated Show resolved Hide resolved

AhmedNSidd added 2 commits July 13, 2019 23:42

Add backend logic to store and create preferences for users

ea25bf0

Add functionality for the availability preferences option and remove …

4f645aa

…the rescheduling preference for tutors

AhmedNSidd changed the title ~~[WIP] settings page added~~ Settings page added Jul 18, 2019

sdevalapurkar reviewed Jul 18, 2019

View reviewed changes

Clean up settings.js code a bit by incorporating shreyas's comments

139dad4

AhmedNSidd merged commit 3a91ab8 into master Jul 19, 2019

This was referenced Jul 19, 2019

Add a settings page #125

Closed

Add a settings option to make lessons respect availabilities or not #120

Closed

AhmedNSidd added a commit that referenced this pull request Jul 30, 2019

Merge pull request #133 from sdevalapurkar/settings-page-added

87c0550

Settings page added

AhmedNSidd added a commit that referenced this pull request Aug 3, 2019

Merge pull request #133 from sdevalapurkar/settings-page-added

cdcbbe5

Settings page added

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Settings page added #133

Settings page added #133

Nppatel97 commented Jun 7, 2019 •

edited

Loading

sdevalapurkar left a comment

Nppatel97 commented Jun 8, 2019

AhmedNSidd commented Jun 12, 2019 •

edited

Loading

Nppatel97 commented Jun 19, 2019

AhmedNSidd commented Jun 19, 2019

sdevalapurkar Jun 19, 2019

Nppatel97 Jun 19, 2019

sdevalapurkar Jun 19, 2019

AhmedNSidd Jun 19, 2019

AhmedNSidd left a comment

DSchriemer commented Jun 20, 2019

Nppatel97 commented Jun 20, 2019

Nppatel97 commented Jun 20, 2019

Nppatel97 commented Jun 29, 2019 •

edited

Loading

AhmedNSidd commented Jun 29, 2019 •

edited

Loading

AhmedNSidd Jun 29, 2019

sdevalapurkar left a comment

sdevalapurkar Jun 30, 2019

AhmedNSidd Jul 12, 2019

sdevalapurkar left a comment

sdevalapurkar left a comment

sdevalapurkar Jul 18, 2019

sdevalapurkar Jul 18, 2019

sdevalapurkar Jul 18, 2019

Settings page added #133

Settings page added #133

Conversation

Nppatel97 commented Jun 7, 2019 • edited Loading

sdevalapurkar left a comment

Choose a reason for hiding this comment

Nppatel97 commented Jun 8, 2019

AhmedNSidd commented Jun 12, 2019 • edited Loading

Nppatel97 commented Jun 19, 2019

AhmedNSidd commented Jun 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AhmedNSidd left a comment

Choose a reason for hiding this comment

DSchriemer commented Jun 20, 2019

Nppatel97 commented Jun 20, 2019

Nppatel97 commented Jun 20, 2019

Nppatel97 commented Jun 29, 2019 • edited Loading

AhmedNSidd commented Jun 29, 2019 • edited Loading

Choose a reason for hiding this comment

sdevalapurkar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdevalapurkar left a comment

Choose a reason for hiding this comment

sdevalapurkar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nppatel97 commented Jun 7, 2019 •

edited

Loading

AhmedNSidd commented Jun 12, 2019 •

edited

Loading

Nppatel97 commented Jun 29, 2019 •

edited

Loading

AhmedNSidd commented Jun 29, 2019 •

edited

Loading